Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: content/browser/bluetooth/bluetooth_metrics.h

Issue 1334763002: bluetooth: Subscribe to notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-origin
Patch Set: Fix global interface test Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/bluetooth/bluetooth_metrics.h
diff --git a/content/browser/bluetooth/bluetooth_metrics.h b/content/browser/bluetooth/bluetooth_metrics.h
index fb1a282d351e949844fdf7ac1da75179c0bbd489..bceb1772a8bd1370089b8a0f1b25b17259ad0ff8 100644
--- a/content/browser/bluetooth/bluetooth_metrics.h
+++ b/content/browser/bluetooth/bluetooth_metrics.h
@@ -29,6 +29,8 @@ enum class UMAWebBluetoothFunction {
GET_CHARACTERISTIC = 3,
CHARACTERISTIC_READ_VALUE = 4,
CHARACTERISTIC_WRITE_VALUE = 5,
+ CHARACTERISTIC_START_NOTIFICATIONS = 6,
+ CHARACTERISTIC_STOP_NOTIFICATIONS = 7,
// NOTE: Add new actions immediately above this line. Make sure to update
// the enum list in tools/metrics/histograms/histograms.xml accordingly.
COUNT
@@ -159,6 +161,7 @@ enum UMAGATTOperationOutcome {
enum class UMAGATTOperation {
CHARACTERISTIC_READ,
CHARACTERISTIC_WRITE,
+ START_NOTIFICATIONS,
// Note: Add new GATT Operations immediately above this line.
COUNT
};
@@ -181,6 +184,12 @@ void RecordCharacteristicReadValueOutcome(UMAGATTOperationOutcome error);
// Send(BluetoothMsg_WriteCharacteristicValueError).
void RecordCharacteristicWriteValueOutcome(UMAGATTOperationOutcome error);
+// Characteristic.startNotifications() Metrics
+// There should be a call to this function for every call to
+// Send(BluetoothMsg_StartNotificationsSuccess) and
+// Send(BluetoothMsg_StopNotificationsError).
+void RecordStartNotificationsOutcome(UMAGATTOperationOutcome outcome);
+
} // namespace content
#endif // CONTENT_BROWSER_BLUETOOTH_BLUETOOTH_METRICS_H_
« no previous file with comments | « content/browser/bluetooth/bluetooth_dispatcher_host.cc ('k') | content/browser/bluetooth/bluetooth_metrics.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698