bluetooth: Subscribe to notifications

third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h
index 609c022c27241c5170009f75cdf927f1d03f6034..a23aad56c965fceb195a14305929f14acbc90c95 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h
@@ -27,7 +27,8 @@ public:
     // Returns the WebBluetooth attached to the ScriptState's frame if that exists;
     // otherwise the Platform's WebBluetooth.
     static WebBluetooth* from(ScriptState*);
-
+    static WebBluetooth* from(ExecutionContext*);
+    static WebBluetooth* from(LocalDOMWindow*);

[haraken, 2015/10/07 01:22:33]

This looks wrong. BluetoothSupplement is a supplement of LocalFrame, so it must
be extracted from LocalFrame (shouldn't be extracted from ExecutionContext,
LocalDOMWindow etc, which has a different lifetime than LocalFrame).

[ortuno, 2015/10/07 17:03:55]

In all three cases we end up getting the supplement from the frame:

scriptState->domWindow()->frame();
executionContext->executingWindow()->frame();
window->frame();

Should we do it differently? Is there another class we should implement to get
the local frame?

     DECLARE_VIRTUAL_TRACE();
 
 private: