bluetooth: Subscribe to notifications

third_party/WebKit/Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/bluetooth/BluetoothGATTCharacteristic.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "modules/bluetooth/BluetoothError.h"
 #include "modules/bluetooth/BluetoothSupplement.h"
 #include "modules/bluetooth/ConvertWebVectorToArrayBuffer.h"
 #include "public/platform/modules/bluetooth/WebBluetooth.h"
 
 namespace blink {
 
-BluetoothGATTCharacteristic::BluetoothGATTCharacteristic(PassOwnPtr<WebBluetoothGATTCharacteristicInit> webCharacteristic)
-    : m_webCharacteristic(webCharacteristic)
+BluetoothGATTCharacteristic::BluetoothGATTCharacteristic(ExecutionContext* context, PassOwnPtr<WebBluetoothGATTCharacteristicInit> webCharacteristic)
+    : ActiveDOMObject(context)
+    , m_webCharacteristic(webCharacteristic)
 {
+    // See note in ActiveDOMObject about suspendIfNeeded.
+    suspendIfNeeded();

[haraken, 2015/10/07 01:22:33]

Nit: Can we move suspendIfNeeded() into the take method? We normally call
suspendIfNeeded() after finishing constructing the object.

[ortuno, 2015/10/07 17:03:55]

Done. Is there any reason for that? I see a couple classes that do it in the
constructor.

+    // See example in Source/platform/heap/ThreadState.h
+    ThreadState::current()->registerPreFinalizer(this);
 }
 
-BluetoothGATTCharacteristic* BluetoothGATTCharacteristic::take(ScriptPromiseResolver*, PassOwnPtr<WebBluetoothGATTCharacteristicInit> webCharacteristic)
+BluetoothGATTCharacteristic* BluetoothGATTCharacteristic::take(ScriptPromiseResolver* resolver, PassOwnPtr<WebBluetoothGATTCharacteristicInit> webCharacteristic)
 {
     if (!webCharacteristic) {
         return nullptr;
     }
-    return new BluetoothGATTCharacteristic(webCharacteristic);
+    return new BluetoothGATTCharacteristic(resolver->executionContext(), webCharacteristic);
+}
+
+void BluetoothGATTCharacteristic::stop()
+{
+    m_stopped = true;
+    WebBluetooth* webbluetooth = BluetoothSupplement::from(ActiveDOMObject::executionContext());
+    webbluetooth->characteristicObjectRemoved(m_webCharacteristic->characteristicInstanceID, this);
+}
+
+void BluetoothGATTCharacteristic::dispose()
+{
+    // stop gets called when the parent document is detached so no need to call
+    // again.

[haraken, 2015/10/07 01:22:33]

Is this comment correct? If the parent document is detached,
ActiveDOMObject::stop() should have been called.

[ortuno, 2015/10/07 17:03:55]

Moved things around a bit to make our intention clearer.

+    if (!m_stopped) {
+        stop();
+    }
 }
 
 ScriptPromise BluetoothGATTCharacteristic::readValue(ScriptState* scriptState)
 {
     WebBluetooth* webbluetooth = BluetoothSupplement::from(scriptState);
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
     ScriptPromise promise = resolver->promise();
     webbluetooth->readValue(m_webCharacteristic->characteristicInstanceID, new CallbackPromiseAdapter<ConvertWebVectorToArrayBuffer, BluetoothError>(resolver));
 
@@ skipping 15 matching lines @@
         return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidModificationError, "Value can't exceed 512 bytes."));
 
     ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
 
     ScriptPromise promise = resolver->promise();
     webbluetooth->writeValue(m_webCharacteristic->characteristicInstanceID, valueVector, new CallbackPromiseAdapter<void, BluetoothError>(resolver));
 
     return promise;
 }
 
+ScriptPromise BluetoothGATTCharacteristic::startNotifications(ScriptState* scriptState)
+{
+    WebBluetooth* webbluetooth = BluetoothSupplement::from(scriptState);
+    ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();
+    webbluetooth->startNotifications(m_webCharacteristic->characteristicInstanceID, this, new CallbackPromiseAdapter<void, BluetoothError>(resolver));
+    return promise;
+}
+
+ScriptPromise BluetoothGATTCharacteristic::stopNotifications(ScriptState* scriptState)
+{
+    WebBluetooth* webbluetooth = BluetoothSupplement::from(scriptState);
+    ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();
+    webbluetooth->stopNotifications(m_webCharacteristic->characteristicInstanceID, this, new CallbackPromiseAdapter<void, BluetoothError>(resolver));
+    return promise;
+}
+
+DEFINE_TRACE(BluetoothGATTCharacteristic)
+{
+    ActiveDOMObject::trace(visitor);
+}
+
 } // namespace blink