bluetooth: Subscribe to notifications

content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 #define CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_
 
 #include "base/callback.h"
 #include "device/bluetooth/test/mock_bluetooth_adapter.h"
 #include "device/bluetooth/test/mock_bluetooth_device.h"
 #include "device/bluetooth/test/mock_bluetooth_discovery_session.h"
 #include "device/bluetooth/test/mock_bluetooth_gatt_characteristic.h"
+#include "device/bluetooth/test/mock_bluetooth_gatt_notify_session.h"
 #include "device/bluetooth/test/mock_bluetooth_gatt_service.h"
 
 namespace content {
 
 // Implements fake adapters with named mock data set for use in tests as a
 // result of layout tests calling testRunner.setBluetoothMockDataSet.
 
 // We have a complete “GenericAccessAdapter”, meaning it has a device which has
 // a Generic Access service with a Device Name characteristic with a descriptor.
 // The other adapters are named based on their particular non-expected behavior.
@@ skipping 129 matching lines @@
   // Internal Structure:
   //  - Generic Access Device
   //     - Generic Access UUID (0x1800)
   //     - Generic Access Service
   //        - Device Name Characteristic:
   //          - Mock Functions:
   //            - Read: Calls success callback with device's name.
   //            - Write: Calls success callback.
   static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
   GetGenericAccessAdapter();
 

[scheib, 2015/10/01 22:05:23]

Changing test data should have corresponding test spec changes, link in change
description.

[ortuno, 2015/10/03 04:03:04]

There is an issue here:
https://github.com/WebBluetoothCG/web-bluetooth/issues/162

+  // |HeartRateAdapter|

[scheib, 2015/10/01 22:05:23]

Why not use GlucoseHeartRateAdapter? For a 'normal' functioning device it seems
it can reuse an existing adapter.

[ortuno, 2015/10/03 04:03:04]

This boils down to a design decision when refactoring this code. The Get*Adapter
methods are the ones that create the functioning device. Get*Device creates the
most basic device.

[scheib, 2015/10/04 01:35:58]

I mean, why not add this implementation to GlucoseHeartRateAdapter? The
additional functionality in GlucoseHeartRateAdapter shouldn't hurt any tests
that use it, and it will reduce the total number of adapters.

[ortuno, 2015/10/06 02:38:43]

Added a note to the bug http://crbug.com/529975. I didn't do it on this CL since
I will need to change other tests.

+  // Inherits from |EmptyAdapter|
+  // Internal Structure:
+  //   - Heart Rate Device
+  //      - Generic Access UUID (0x1800)
+  //      - Heart Rate UUID (0x180D)
+  //      - Heart Rate Service
+  //         - Heart Rate Measurement Characteristic:
+  //            - Mock Functions:
+  //               - StartNotifySession: Calls success callback with a
+  //                 BaseGATTNotifySession(characteristic_instance_id)
+  static scoped_refptr<testing::NiceMock<device::MockBluetoothAdapter>>
+  GetHeartRateAdapter();
+
   // |FailingConnectionsAdapter|
   // Inherits from |EmptyAdapter|
   // FailingConnectionsAdapter holds a device for each type of connection error
   // that can occur. This way we don’t need to create an adapter for each type
   // of error. Each of the devices has a service with a different UUID so that
   // they can be accessed by using different filters.
   // See errorUUID() declaration below.
   // Internal Structure:
   //  - UnconnectableDevice(BluetoothDevice::ERROR_UNKNOWN)       errorUUID(0x0)
   //  - UnconnectableDevice(BluetoothDevice::ERROR_INPROGRESS)    errorUUID(0x1)
@@ skipping 107 matching lines @@
   //                            "00:00:00:00:00:02")
   // Adv UUIDs added:
   //   - Generic Access (0x1800)
   //   - Glucose UUID (0x1808)
   // Services added:
   // None.
   static scoped_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetGlucoseDevice(device::MockBluetoothAdapter* adapter);
 
   // |HeartRateDevice|
   // Inherits from |BaseDevice|(adapter, "Heart Rate Device", uuids,

[scheib, 2015/10/01 22:05:23]

from |ConnectableDevice|

[ortuno, 2015/10/03 04:03:04]

Done.

   //                            "00:00:00:00:00:03")
   // Adv UUIDs added:
   //   - Generic Access (0x1800)
   //   - Heart Rate UUID (0x180D)
   // Services added:
   // None.
   static scoped_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetHeartRateDevice(device::MockBluetoothAdapter* adapter);
 
   // |ConnectableDevice|
   // Inherits from |BaseDevice|(adapter, device_name)
   // Adv UUIDs added:
   // None.
   // Services added:
   // None.
   // Mock Functions:
   //   - CreateGattConnection:
   //       - Run success callback with BaseGATTConnection
   static scoped_ptr<testing::NiceMock<device::MockBluetoothDevice>>
   GetConnectableDevice(
       device::MockBluetoothAdapter* adapter,
       const std::string& device_name = "Connectable Device",
-      device::BluetoothDevice::UUIDList = device::BluetoothDevice::UUIDList());
+      device::BluetoothDevice::UUIDList = device::BluetoothDevice::UUIDList(),
+      const std::string& address = "00:00:00:00:00:00");
 
   // |UnconnectableDevice|
   // Inherits from |BaseDevice|(adapter, device_name)
   // Adv UUIDs added:
   //  - errorUUID(error_code)
   // Services added:
   // None.
   // Mock Functions:
   //  - CreateGATTConnection:
   //      - Run error callback with error_type
@@ skipping 60 matching lines @@
   //   - GetService:
   //       Returns: service
   //   - GetProperties:
   //       Returns: NULL
   //   - GetPermissions:
   //       Returns: NULL
   static scoped_ptr<testing::NiceMock<device::MockBluetoothGattCharacteristic>>
   GetBaseGATTCharacteristic(device::MockBluetoothGattService* service,
                             const std::string& uuid);
 
+  // Notify Sessions
+
+  // |BaseGATTNotifySession|(characteristic_identifier)
+  // Mock Functions:
+  //   - GetCharacteristicIdentifier:
+  //       Returns: characteristic_identifier
+  //   - IsActive:
+  //       Returns: true
+  //   - Stop:
+  //       Run callback.
+  static scoped_ptr<testing::NiceMock<device::MockBluetoothGattNotifySession>>
+  GetBaseGATTNotifySession(const std::string& characteristic_identifier);
+
   // |ErrorCharacteristic|(service, error_type)
   // Inherits from BaseCharacteristic(service, errorUUID(error_type + 0xA1))
   // Descriptors added:
   // None.
   // Mock Functions:
   //   - ReadRemoteCharacteristic:
   //       Run error callback with error_type
   //   - WriteRemoteCharacteristic:
   //       Run error callback with error_type
+  //   - StartNotifySession:
+  //       Run error callback with error_type
   static scoped_ptr<testing::NiceMock<device::MockBluetoothGattCharacteristic>>
   GetErrorCharacteristic(
       device::MockBluetoothGattService* service,
       device::BluetoothGattService::GattErrorCode error_code);
 
   // Helper functions:
 
   // errorUUID(alias) returns a UUID with the top 32 bits of
   // "00000000-97e5-4cd7-b9f1-f5a427670c59" replaced with the bits of |alias|.
   // For example, errorUUID(0xDEADBEEF) returns
   // "deadbeef-97e5-4cd7-b9f1-f5a427670c59". The bottom 96 bits of error UUIDs
   // were generated as a type 4 (random) UUID.
   static std::string errorUUID(uint32_t alias);
 
   // Function to turn an integer into an MAC address of the form
   // XX:XX:XX:XX:XX:XX. For example makeMACAddress(0xdeadbeef)
   // returns "00:00:DE:AD:BE:EF".
   static std::string makeMACAddress(uint64_t addr);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_SHELL_BROWSER_LAYOUT_TEST_LAYOUT_TEST_BLUETOOTH_ADAPTER_PROVIDER_H_