Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: Source/config.gyp

Issue 133473002: Add blink_gc_plugin variable to enable the clang plugin for checking GC consistency. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Reverted gyp setup restructuring Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/config.gyp
diff --git a/Source/config.gyp b/Source/config.gyp
index 390d073ef11b61aea7f7cfed7cc2e89d2b053762..cb59e052e93d9890dd03b4f26a76b5e5769085be 100644
--- a/Source/config.gyp
+++ b/Source/config.gyp
@@ -32,6 +32,10 @@
# If set to 1, doesn't compile debug symbols into webcore reducing the
# size of the binary and increasing the speed of gdb. gcc only.
'remove_webcore_debug_symbols%': 0,
+ # Set to 1 to enable the clang plugin that checks the usage of the Blink
+ # garbage-collection infrastructure during compilation.
+ # Requires building locally since GOMA doesn't yet support the plugin.
+ 'blink_gc_plugin%': 0,
},
'targets': [
{
@@ -98,6 +102,10 @@
'WARNING_CFLAGS': ['-Wglobal-constructors'],
},
}],
+ # Only enable the blink_gc_plugin when using clang and chrome plugins.
+ ['blink_gc_plugin==1 and clang==1 and clang_use_chrome_plugins==1', {
+ 'cflags': ['<!@(../../../tools/clang/scripts/blink_gc_plugin_flags.sh)'],
+ }],
],
},
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698