Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1334713002: Check renderability of images in a (-webkit-)cross-fade before using (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
chrishtr, f(malita)
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Check renderability of images in a (-webkit-)cross-fade before using If the image fails to decode or otherwise trigger an error, we don't want to render it, since it will render (or measure) the "broken image" placeholder. BUG=111512 Committed: https://crrev.com/b7cdac20905928fa67fbe650f3c3e4b431c50a2f git-svn-id: svn://svn.chromium.org/blink/trunk@202122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Update fixedSize() too; Add helper. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
A LayoutTests/css3/images/cross-fade-broken-image.html View 1 chunk +2 lines, -0 lines 0 comments Download
A + LayoutTests/css3/images/cross-fade-broken-image-expected.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/CSSCrossfadeValue.cpp View 1 3 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 3 months ago (2015-09-10 15:57:56 UTC) #2
f(malita)
lgtm
5 years, 3 months ago (2015-09-10 16:18:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334713002/20001
5 years, 3 months ago (2015-09-11 08:20:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202122
5 years, 3 months ago (2015-09-11 08:59:40 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:20:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7cdac20905928fa67fbe650f3c3e4b431c50a2f

Powered by Google App Engine
This is Rietveld 408576698