Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334703002: NOT FOR LANDING Pass URL to Image::draw (Closed)

Created:
5 years, 3 months ago by davve
Modified:
5 years ago
Reviewers:
CC:
blink-reviews, dshwang, eae+blinkwatch, fs, dcheng, apavlov+blink_chromium.org, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, Yoav Weiss, krit, drott+blinkwatch_chromium.org, blink-reviews-css, szager+layoutwatch_chromium.org, Justin Novosad, danakj, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, gyuyoung2, pdr+svgwatchlist_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, jbroman, pdr+graphicswatchlist_chromium.org, darktears, Nate Chapin, tyoshino+watch_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

NOT FOR LANDING Pass URL to Image::draw Proof of concept for passing URLs to Image::draw to be able to support painting fragments (of SVG images). BUG=128055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -106 lines) Patch
A LayoutTests/svg/css/svg-resource-fragment-identifier-background.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-background-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-background-srcset.html View 1 chunk +13 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-background-srcset-expected.html View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/svg/css/svg-resource-fragment-identifier-img-src.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/css/svg-resource-fragment-identifier-img-src-expected.html View 1 chunk +1 line, -1 line 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-input.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-input-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-svg-image.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-svg-image-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-video-poster.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/svg/css/svg-resource-fragment-identifier-video-poster-expected.html View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/fetch/ImageResource.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/core/layout/ImageQualityControllerTest.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutImage.cpp View 2 chunks +18 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutImageResource.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M Source/core/layout/shapes/Shape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/BoxPainter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/paint/ImagePainter.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/paint/ImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ListMarkerPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/MediaControlsPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/ScrollableAreaPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/paint/ThemePainterDefault.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/VideoPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleFetchedImage.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/style/StyleFetchedImage.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/style/StyleFetchedImageSet.h View 2 chunks +5 lines, -3 lines 0 comments Download
M Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/style/StyleImage.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/style/StylePendingImage.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 7 chunks +8 lines, -7 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/DragImageTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/BitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/CrossfadeGeneratedImage.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/platform/graphics/GeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GradientGeneratedImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/GraphicsContext.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/platform/graphics/GraphicsContext.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/platform/graphics/Image.h View 2 chunks +8 lines, -6 lines 0 comments Download
M Source/platform/graphics/Image.cpp View 5 chunks +9 lines, -7 lines 0 comments Download
M Source/platform/graphics/ImageBufferSurface.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/graphics/ImageLayerChromiumTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/StaticBitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/StaticBitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (1 generated)
davve
5 years ago (2015-12-03 13:28:49 UTC) #1 
Description was changed from

==========
NOT FOR LANDING Pass URL to Image::draw

Proof of concept for passing URLs to Image::draw to be able to support
painting fragments (of SVG images).

BUG=128055
==========

to

==========
NOT FOR LANDING Pass URL to Image::draw

Proof of concept for passing URLs to Image::draw to be able to support
painting fragments (of SVG images).

BUG=128055
==========

Powered by Google App Engine
This is Rietveld 408576698