Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1334673004: Memory-infra: Change "objects_count" to "object_count" in category name. (Closed)

Created:
5 years, 3 months ago by Daniel Bratell
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@locked_discarded_20150910
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Memory-infra: Change "objects_count" to "object_count" in category name. TBR=thakis@chromium.org BUG= Committed: https://crrev.com/10f2e3c531ebed7829742c1f6b0d70c6006eee60 Cr-Commit-Position: refs/heads/master@{#348166}

Patch Set 1 : Rebased. #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M base/trace_event/memory_allocator_dump.h View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_allocator_dump.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/memory_allocator_dump_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M base/trace_event/trace_event_memory_overhead.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/winheap_dump_provider_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/discardable_shared_memory_heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M gin/v8_isolate_memory_dump_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/skia_memory_dump_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (8 generated)
Daniel Bratell
I believe the proper expression is "object count" so we better use that term in ...
5 years, 3 months ago (2015-09-10 12:53:29 UTC) #3
Primiano Tucci (use gerrit)
On 2015/09/10 12:53:29, Daniel Bratell wrote: > I believe the proper expression is "object count" ...
5 years, 3 months ago (2015-09-10 13:07:00 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-10 15:18:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334673004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334673004/40001
5 years, 3 months ago (2015-09-10 15:22:03 UTC) #8
Primiano Tucci (use gerrit)
On 2015/09/10 15:22:03, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-09-10 15:32:10 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/98210)
5 years, 3 months ago (2015-09-10 15:34:34 UTC) #11
Daniel Bratell
On 2015/09/10 15:32:10, Primiano Tucci wrote: > I think presubmit will fail you still need ...
5 years, 3 months ago (2015-09-10 15:41:50 UTC) #12
Daniel Bratell
fmalita, could you please rubberstamp something nice on the variable rename in skia/ext?
5 years, 3 months ago (2015-09-10 15:43:08 UTC) #14
Primiano Tucci (use gerrit)
On 2015/09/10 15:41:50, Daniel Bratell wrote: > On 2015/09/10 15:32:10, Primiano Tucci wrote: > > ...
5 years, 3 months ago (2015-09-10 15:43:08 UTC) #15
Primiano Tucci (use gerrit)
TBR-ing thakis for one char change in /skia/ext
5 years, 3 months ago (2015-09-10 15:54:54 UTC) #17
Primiano Tucci (use gerrit)
TBR-ing thakis for one char change in /skia/ext
5 years, 3 months ago (2015-09-10 15:54:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334673004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334673004/40001
5 years, 3 months ago (2015-09-10 15:55:12 UTC) #20
f(malita)
On 2015/09/10 15:43:08, Daniel Bratell wrote: > fmalita, could you please rubberstamp something nice on ...
5 years, 3 months ago (2015-09-10 16:11:06 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-10 16:28:50 UTC) #22
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/10f2e3c531ebed7829742c1f6b0d70c6006eee60 Cr-Commit-Position: refs/heads/master@{#348166}
5 years, 3 months ago (2015-09-10 16:29:35 UTC) #23
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:11:16 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/10f2e3c531ebed7829742c1f6b0d70c6006eee60
Cr-Commit-Position: refs/heads/master@{#348166}

Powered by Google App Engine
This is Rietveld 408576698