Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 1334673003: Add instrumentation to track down a crasher (Closed)

Created:
5 years, 3 months ago by Jakob Kummerow
Modified:
5 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add instrumentation to track down a crasher LoadICs must always return a JS-accessible value (nothing internal). Dictionary property keys are guaranteed to be unique names. BUG=chromium:527994 LOG=n Committed: https://crrev.com/071d03a431237ad31a11533b572ff647801ac82c Cr-Commit-Position: refs/heads/master@{#30683}

Patch Set 1 #

Patch Set 2 : save receiver and push it before crashing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -8 lines) Patch
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
As discussed. It would be nice to push the receiver (and its map, and its ...
5 years, 3 months ago (2015-09-10 12:46:52 UTC) #2
mvstanton
lgtm
5 years, 3 months ago (2015-09-10 13:04:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334673003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334673003/20001
5 years, 3 months ago (2015-09-10 13:41:10 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-10 14:07:45 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 14:08:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/071d03a431237ad31a11533b572ff647801ac82c
Cr-Commit-Position: refs/heads/master@{#30683}

Powered by Google App Engine
This is Rietveld 408576698