Stub clang plugin to check consistency of the Blink GC infrastructure.

tools/clang/scripts/update.sh

 #!/usr/bin/env bash
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This script will check out llvm and clang into third_party/llvm and build it.
 
 # Do NOT CHANGE this if you don't know what you're doing -- see
 # https://code.google.com/p/chromium/wiki/UpdatingClang
 # Reverting problematic clang rolls is safe, though.
@@ skipping 279 matching lines @@
   cd "${LLVM_BUILD_DIR}"
   make -C tools/clang/runtime/ \
     LLVM_ANDROID_TOOLCHAIN_DIR="../../../llvm-build/android-toolchain"
   cd -
 fi
 
 # Build Chrome-specific clang tools. Paths in this list should be relative to
 # tools/clang.
 # For each tool directory, copy it into the clang tree and use clang's build
 # system to compile it.
 for CHROME_TOOL_DIR in ${chrome_tools}; do

[hans, 2014/01/21 21:22:12]

It looks like this for loop only runs one iteration.

I guess the new thing only gets built if one passes "--chrome-tools=plugins
blink_gc_plugin", and I obviously didn't pass that.

   TOOL_SRC_DIR="${THIS_DIR}/../${CHROME_TOOL_DIR}"
   TOOL_DST_DIR="${LLVM_DIR}/tools/clang/tools/chrome-${CHROME_TOOL_DIR}"
   TOOL_BUILD_DIR="${LLVM_BUILD_DIR}/tools/clang/tools/chrome-${CHROME_TOOL_DIR}"
   rm -rf "${TOOL_DST_DIR}"
   cp -R "${TOOL_SRC_DIR}" "${TOOL_DST_DIR}"
   rm -rf "${TOOL_BUILD_DIR}"
   mkdir -p "${TOOL_BUILD_DIR}"
   cp "${TOOL_SRC_DIR}/Makefile" "${TOOL_BUILD_DIR}"

[Nico, 2014/01/21 21:08:49]

I thought it would get build here. Maybe the new plugin is missing a makefile.

   MACOSX_DEPLOYMENT_TARGET=10.5 make -j"${NUM_JOBS}" -C "${TOOL_BUILD_DIR}"
 done
 
 if [[ -n "$run_tests" ]]; then
   # Run a few tests.
-  PLUGIN_SRC_DIR="${THIS_DIR}/../plugins"
-  "${PLUGIN_SRC_DIR}/tests/test.sh" "${LLVM_BUILD_DIR}/Release+Asserts"
+  for CHROME_TOOL_DIR in ${chrome_tools}; do
+    TOOL_SRC_DIR="${THIS_DIR}/../${CHROME_TOOL_DIR}"
+    if [[ -f "${TOOL_SRC_DIR}/tests/test.sh" ]]; then
+      "${TOOL_SRC_DIR}/tests/test.sh" "${LLVM_BUILD_DIR}/Release+Asserts"
+    fi
+  done
   cd "${LLVM_BUILD_DIR}"
   make check-all
   cd -
 fi
 
 # After everything is done, log success for this revision.
 echo "${CLANG_REVISION}" > "${STAMP_FILE}"