Issue 1334603002: Revert of Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessin…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1334603002: Revert of Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessin… (Closed)

Created:
5 years, 3 months ago by bsalomon

Modified:
5 years, 3 months ago

Reviewers:
reed2, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessin… (patchset #1 id:1 of https://codereview.chromium.org/1329313002/ ) Reason for revert: breaking the bots Original issue's description: > Add a mutex to GrContext::readSurfacePixels to protect against multiple CPU raster threads accessing the same GrContext to read back GPU input data > > BUG=chromium:524717 > > TBR=reed@google.com > > Committed: https://skia.googlesource.com/skia/+/eb662bc407cec0585a821946fef123102cae64db TBR=reed@google.com,reed@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524717 Committed: https://skia.googlesource.com/skia/+/32ab260ee18ab53611bcd2eefde535b6e31f9d8d

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	include/gpu/GrContext.h	View		2 chunks	+0 lines, -6 lines	0 comments	Download
	M	src/gpu/GrContext.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 1 (0 generated)

bsalomon

5 years, 3 months ago (2015-09-10 01:57:34 UTC) #1

Created Revert of Add a mutex to GrContext::readSurfacePixels to protect against
multiple CPU raster threads accessin…