Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: net/tools/quic/end_to_end_test.cc

Issue 1334583002: relnote: Deprecate FLAGS_quic_allow_ip_migration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Cache_align_encryption_101462412
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/end_to_end_test.cc
diff --git a/net/tools/quic/end_to_end_test.cc b/net/tools/quic/end_to_end_test.cc
index b2e2a0feef5fcfd3d3c36e993d09fa99f06317c5..944105ec165dcf9387123c71b9c21284b68db0a1 100644
--- a/net/tools/quic/end_to_end_test.cc
+++ b/net/tools/quic/end_to_end_test.cc
@@ -1359,9 +1359,6 @@ class WrongAddressWriter : public QuicPacketWriterWrapper {
};
TEST_P(EndToEndTest, ConnectionMigrationClientIPChanged) {
- // Allow client IP migration during an established QUIC connection.
- ValueRestore<bool> old_flag(&FLAGS_quic_allow_ip_migration, true);
-
ASSERT_TRUE(Initialize());
EXPECT_EQ(kFooResponseBody, client_->SendSynchronousRequest("/foo"));
@@ -1381,29 +1378,6 @@ TEST_P(EndToEndTest, ConnectionMigrationClientIPChanged) {
EXPECT_EQ(200u, client_->response_headers()->parsed_response_code());
}
-TEST_P(EndToEndTest, ConnectionMigrationClientIPChangedUnsupported) {
- // Tests that the client's IP can not change during an established QUIC
- // connection. If it changes, the connection is closed by the server as we
- // do not yet support IP migration.
- ValueRestore<bool> old_flag(&FLAGS_quic_allow_ip_migration, false);
-
- ASSERT_TRUE(Initialize());
-
- EXPECT_EQ(kFooResponseBody, client_->SendSynchronousRequest("/foo"));
- EXPECT_EQ(200u, client_->response_headers()->parsed_response_code());
-
- WrongAddressWriter* writer = new WrongAddressWriter();
-
- writer->set_writer(new QuicDefaultPacketWriter(client_->client()->fd()));
- QuicConnectionPeer::SetWriter(client_->client()->session()->connection(),
- writer, /* owns_writer= */ true);
-
- client_->SendSynchronousRequest("/bar");
-
- EXPECT_EQ(QUIC_STREAM_CONNECTION_ERROR, client_->stream_error());
- EXPECT_EQ(QUIC_ERROR_MIGRATING_ADDRESS, client_->connection_error());
-}
-
TEST_P(EndToEndTest, ConnectionMigrationClientPortChanged) {
// Tests that the client's port can change during an established QUIC
// connection, and that doing so does not result in the connection being
« no previous file with comments | « net/quic/quic_flags.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698