Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1334543002: Revert of more zero-length changes for svg compatibility (Closed)

Created:
5 years, 3 months ago by caryclark
Modified:
5 years, 3 months ago
Reviewers:
fs, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of more zero-length changes for svg compatibility (patchset #6 id:100001 of https://codereview.chromium.org/1330623003/ ) Reason for revert: breaks DEPS Original issue's description: > more zero-length changes for svg compatibility > > If a path contains a moveTo followed by a line or curve, > even if the line or curve has no length, SVG expects > the end caps to draw if the cap style is round or square. > > Fredrik Söderquist attached a patch to the chrome bug > (slightly modified here) that fixes layout test failures > resulting from deleting special-case code in SVG > dealing with zero-length path segments. > > R=reed@google.com,fs@opera.com > BUG=22974 > > Committed: https://skia.googlesource.com/skia/+/62fb1ba1786863e545c89839b5706ad5151cec15 TBR=fs@opera.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=22974 Committed: https://skia.googlesource.com/skia/+/5ca4fa3846067a47e88d35ace895df3ebe3ec2a5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -41 lines) Patch
M gm/strokes.cpp View 2 chunks +0 lines, -10 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkStroke.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M tests/EmptyPathTest.cpp View 3 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
caryclark
Created Revert of more zero-length changes for svg compatibility
5 years, 3 months ago (2015-09-09 16:34:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334543002/1
5 years, 3 months ago (2015-09-09 16:34:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5ca4fa3846067a47e88d35ace895df3ebe3ec2a5
5 years, 3 months ago (2015-09-09 16:34:25 UTC) #3
caryclark
5 years, 3 months ago (2015-09-09 20:20:33 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1314833004/ by caryclark@google.com.

The reason for reverting is: DEPS should be fixed now.

Powered by Google App Engine
This is Rietveld 408576698