Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1334513002: Fold FormDataList::getEntry(index) into DOMFormData. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fold FormDataList::getEntry(index) into DOMFormData. Fold FormDataList::getEntry(index) into DOMFormData without creating FormDataList::Entry. - Add Item::file() to share code between itemsToEntry() and DOMFormDataIterationSource::next(). - Add Item::isString() and isFile() for compatibility with Entry. - Add DOMFormData::decode() to decode CStrings in Item. This CL has no behavior changes. BUG=528840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201957

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -23 lines) Patch
M Source/core/html/DOMFormData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/html/DOMFormData.cpp View 2 chunks +12 lines, -7 lines 0 comments Download
M Source/core/html/FormDataList.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/FormDataList.cpp View 2 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Keishi, would you review this please?
5 years, 3 months ago (2015-09-09 06:07:30 UTC) #3
keishi
LGTM
5 years, 3 months ago (2015-09-09 06:56:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334513002/20001
5 years, 3 months ago (2015-09-09 06:57:19 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 07:02:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201957

Powered by Google App Engine
This is Rietveld 408576698