Add GPU fingerprint information to breakpad microdumps.

src/client/linux/handler/microdump_extra_info.h

Index: src/client/linux/handler/microdump_extra_info.h
diff --git a/src/tools/solaris/dump_syms/testdata/dump_syms_regtest.cc b/src/client/linux/handler/microdump_extra_info.h
similarity index 69%
copy from src/tools/solaris/dump_syms/testdata/dump_syms_regtest.cc
copy to src/client/linux/handler/microdump_extra_info.h
index e617a23b813286dfe791051a7867f45a8b2f63e4..9fddc00b074a96da747044362ade9859b1d0a56a 100644
--- a/src/tools/solaris/dump_syms/testdata/dump_syms_regtest.cc
+++ b/src/client/linux/handler/microdump_extra_info.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2007, Google Inc.
+// Copyright 2015 Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
@@ -27,38 +27,27 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// ./dump_syms dump_syms_regtest.pdb > dump_syms_regtest.sym
+#ifndef CLIENT_LINUX_HANDLER_MICRODUMP_EXTRA_INFO_H_
+#define CLIENT_LINUX_HANDLER_MICRODUMP_EXTRA_INFO_H_
 
 namespace google_breakpad {
 
-class C {
- public:
-  C() : member_(1) {}
-  virtual ~C() {}
+struct MicrodumpExtraInfo {
+  const char* build_fingerprint;
+  const char* product_info;
+  const char* gpu_fingerprint;
 
-  void set_member(int value) { member_ = value; }
-  int member() const { return member_; }
+MicrodumpExtraInfo()
+      : build_fingerprint(NULL), product_info(NULL), gpu_fingerprint(NULL) {}
 
-  void f() { member_ = g(); }
-  virtual int g() { return 2; }
-  static char* h(const C &that) { return 0; }
-
- private:
-  int member_;
+MicrodumpExtraInfo(const char* build_fingerprint_val,

[Primiano Tucci (use gerrit), 2015/09/10 12:38:58]

please add a comment clarifying that all the const* char strings here must be
guaranteed to be long-lived (i.e. they should be either literals or strduped
from the callers)

[Tobias Sargeant, 2015/09/10 13:18:38]

Done.

+                   const char* product_info_val,
+                   const char* gpu_fingerprint_val)
+    : build_fingerprint(build_fingerprint_val),
+      product_info(product_info_val),
+      gpu_fingerprint(gpu_fingerprint_val) {}
 };
 
-static int i() {
-  return 3;
 }
 
-}  // namespace google_breakpad
-
-int main(int argc, char **argv) {
-  google_breakpad::C object;
-  object.set_member(google_breakpad::i());
-  object.f();
-  int value = object.g();
-  char *nothing = object.h(object);
-
-  return 0;
-}
+#endif  // CLIENT_LINUX_HANDLER_MICRODUMP_EXTRA_INFO_H_