Add GPU fingerprint information to breakpad microdumps.

src/client/linux/microdump_writer/microdump_writer_unittest.cc

 // Copyright (c) 2014 Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 36 matching lines @@
 using namespace google_breakpad;
 
 namespace {
 
 typedef testing::Test MicrodumpWriterTest;
 
 void CrashAndGetMicrodump(
     const MappingList& mappings,
     const char* build_fingerprint,
     const char* product_info,
+    const char* gpu_fingerprint,
     scoped_array<char>* buf) {
   int fds[2];
   ASSERT_NE(-1, pipe(fds));
 
   AutoTempDir temp_dir;
   string stderr_file = temp_dir.path() + "/stderr.log";
   int err_fd = open(stderr_file.c_str(), O_CREAT | O_RDWR, S_IRUSR | S_IWUSR);
   ASSERT_NE(-1, err_fd);
 
   const pid_t child = fork();
@@ skipping 11 matching lines @@
 
   // Set a non-zero tid to avoid tripping asserts.
   context.tid = child;
 
   // Redirect temporarily stderr to the stderr.log file.
   int save_err = dup(STDERR_FILENO);
   ASSERT_NE(-1, save_err);
   ASSERT_NE(-1, dup2(err_fd, STDERR_FILENO));
 
   ASSERT_TRUE(WriteMicrodump(child, &context, sizeof(context), mappings,
-      build_fingerprint, product_info));
+                             build_fingerprint, product_info, gpu_fingerprint));
 
   // Revert stderr back to the console.
   dup2(save_err, STDERR_FILENO);
   close(save_err);
 
   // Read back the stderr file and check for the microdump marker.
   fsync(err_fd);
   lseek(err_fd, 0, SEEK_SET);
   const size_t kBufSize = 64 * 1024;
   buf->reset(new char[kBufSize]);
   ASSERT_GT(read(err_fd, buf->get(), kBufSize), 0);
 
   close(err_fd);
   close(fds[1]);
 
   ASSERT_NE(static_cast<char*>(0), strstr(
       buf->get(), "-----BEGIN BREAKPAD MICRODUMP-----"));
   ASSERT_NE(static_cast<char*>(0), strstr(
       buf->get(), "-----END BREAKPAD MICRODUMP-----"));
 }
 
 void CheckMicrodumpContents(const string &microdum_content,
                             const string &expected_fingerprint,
                             const string &expected_product_info) {

[Primiano Tucci (use gerrit), 2015/09/09 18:59:34]

would be nice if this was covering also the gpu fingerprint here

[Tobias Sargeant, 2015/09/10 10:45:04]

Done.

   std::istringstream iss(microdum_content);
   bool did_find_os_info = false;
   bool did_find_product_info = false;
   for (string line; std::getline(iss, line);) {
     if (line.find("O ") == 0) {
       std::istringstream os_info_tokens(line);
       string token;
       os_info_tokens.ignore(2); // Ignore the "O " preamble.
       // Check the OS descriptor char (L=Linux, A=Android).
       os_info_tokens >> token;
@@ skipping 73 matching lines @@
 
 TEST(MicrodumpWriterTest, NoProductInfo) {
   const char kBuildFingerprint[] = "foobar";
   scoped_array<char> buf;
   MappingList no_mappings;
 
   CrashAndGetMicrodump(no_mappings, kBuildFingerprint, NULL, &buf);
   CheckMicrodumpContents(string(buf.get()), kBuildFingerprint, "UNKNOWN:0.0.0.0");
 }
 }  // namespace