Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 133443011: Add text field change handling for autofill preview in textarea element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Update code as per tkent's comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index 6df23221b636684f7d0f23f62d5cfaec6edd172d..92e4a5ee99ed66664c1af399b76614b858dfa825 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -903,6 +903,8 @@ void ChromeClientImpl::forwardInputEvent(
}
}
+// TODO(ziran.sun): This function is to be removed once both chromium and blink changes
tkent 2014/03/05 23:18:39 TODO() -> FIXME
+// for BUG332557 are in.
void ChromeClientImpl::didChangeValueInTextField(HTMLInputElement& inputElement)
{
if (!m_webView->autofillClient())
@@ -910,6 +912,13 @@ void ChromeClientImpl::didChangeValueInTextField(HTMLInputElement& inputElement)
m_webView->autofillClient()->textFieldDidChange(WebInputElement(&inputElement));
}
+void ChromeClientImpl::didChangeValueInTextField(HTMLFormControlElement& element)
+{
+ if (!m_webView->autofillClient())
+ return;
+ m_webView->autofillClient()->textFieldDidChange(WebFormControlElement(&element));
+}
+
void ChromeClientImpl::didEndEditingOnTextField(HTMLInputElement& inputElement)
{
if (m_webView->autofillClient())

Powered by Google App Engine
This is Rietveld 408576698