Source/web/ChromeClientImpl.h - Issue 133443011: Add text field change handling for autofill preview in textarea element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.h

Issue 133443011: Add text field change handling for autofill preview in textarea element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update code as per review comments from tkent and jamesr Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.h

diff --git a/Source/web/ChromeClientImpl.h b/Source/web/ChromeClientImpl.h

index 3eb23378b94bb0748a2c0e220224eeb66bbce4a5..bebd11cc6c81e53af3668a08338624de49f8272d 100644

--- a/Source/web/ChromeClientImpl.h

+++ b/Source/web/ChromeClientImpl.h

@@ -48,6 +48,7 @@ class Element;

class Event;

class FileChooser;

class GraphicsLayerFactory;

+class HTMLFormControlElement;

class HTMLInputElement;

class KeyboardEvent;

class PopupMenuClient;

@@ -177,7 +178,7 @@ public:

virtual void requestPointerUnlock() OVERRIDE;

virtual void didAssociateFormControls(const Vector<RefPtr<WebCore::Element> >&) OVERRIDE;

- virtual void didChangeValueInTextField(WebCore::HTMLInputElement&) OVERRIDE;

+ virtual void didChangeValueInTextField(WebCore::HTMLFormControlElement&) OVERRIDE;

virtual void didEndEditingOnTextField(WebCore::HTMLInputElement&) OVERRIDE;

virtual void handleKeyboardEventOnTextField(WebCore::HTMLInputElement&, WebCore::KeyboardEvent&) OVERRIDE;

« no previous file with comments | « Source/core/page/ChromeClient.h ('k') | Source/web/ChromeClientImpl.cpp » ('j') | Source/web/ChromeClientImpl.cpp » ('J')