Source/web/ChromeClientImpl.cpp - Issue 133443011: Add text field change handling for autofill preview in textarea element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 133443011: Add text field change handling for autofill preview in textarea element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update code as per review comments from tkent and jamesr Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 47efada7eef3593699f8a5f7d2907756119c66e0..23028366aaf8dfe84a64e583e325c10f13e61982 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -910,11 +910,11 @@ void ChromeClientImpl::forwardInputEvent(

}

-void ChromeClientImpl::didChangeValueInTextField(HTMLInputElement& inputElement)

+void ChromeClientImpl::didChangeValueInTextField(HTMLFormControlElement& element)

{

if (!m_webView->autofillClient())

return;

- m_webView->autofillClient()->textFieldDidChange(WebInputElement(&inputElement));

+ m_webView->autofillClient()->textFieldDidChange(WebFormControlElement(&element));

tkent 2014/03/04 23:43:58 Please call textFieldDidChange(WebInputElement(...

ziran.sun 2014/03/05 14:29:02 Done.

}

void ChromeClientImpl::didEndEditingOnTextField(HTMLInputElement& inputElement)

« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | Source/web/WebFormControlElement.cpp » ('j') | Source/web/WebFormControlElement.cpp » ('J')