Source/web/ChromeClientImpl.cpp - Issue 133443011: Add text field change handling for autofill preview in textarea element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 133443011: Add text field change handling for autofill preview in textarea element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/ChromeClientImpl.cpp

diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp

index 51dfa2c97c78619911872adeb6681c208b479c0c..ddfffbf0d940ca22de994fb3fe023762c3f2cbcb 100644

--- a/Source/web/ChromeClientImpl.cpp

+++ b/Source/web/ChromeClientImpl.cpp

@@ -999,11 +999,13 @@ void ChromeClientImpl::forwardInputEvent(

}

-void ChromeClientImpl::didChangeValueInTextField(HTMLInputElement& inputElement)

+void ChromeClientImpl::didChangeValueInTextField(

+ HTMLFormControlElement& element)

tkent 2014/02/06 00:05:45 You don't need to wrap the line.

ziran.sun 2014/02/06 10:32:17 Done.

{

if (!m_webView->autofillClient())

return;

- m_webView->autofillClient()->textFieldDidChange(WebInputElement(&inputElement));

+ m_webView->autofillClient()->textFieldDidChange(

tkent 2014/02/06 00:05:45 Ditto.

ziran.sun 2014/02/06 10:32:17 Done.

+ WebFormControlElement(&element));

}

void ChromeClientImpl::didEndEditingOnTextField(HTMLInputElement& inputElement)

« Source/core/html/HTMLTextAreaElement.cpp ('K') | « Source/web/ChromeClientImpl.h ('k') | Source/web/WebTextAreaElement.cpp » ('j') | public/web/WebAutofillClient.h » ('J')