A64: Synchronize with r17441.

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 23 matching lines @@
 #include "factory.h"
 #include "gdb-jit.h"
 #include "macro-assembler.h"
 
 namespace v8 {
 namespace internal {
 
 
 CodeStubInterfaceDescriptor::CodeStubInterfaceDescriptor()
     : register_param_count_(-1),
-      stack_parameter_count_(NULL),
+      stack_parameter_count_(no_reg),
       hint_stack_parameter_count_(-1),
       function_mode_(NOT_JS_FUNCTION_STUB_MODE),
       register_params_(NULL),
       deoptimization_handler_(NULL),
       miss_handler_(),
       has_miss_handler_(false) { }
 
 
 bool CodeStub::FindCodeInCache(Code** code_out, Isolate* isolate) {
   UnseededNumberDictionary* stubs = isolate->heap()->code_stubs();
@@ skipping 67 matching lines @@
       GetICState(),
       GetExtraICState(),
       GetStubType(),
       GetStubFlags());
   Handle<Code> new_object = factory->NewCode(
       desc, flags, masm.CodeObject(), NeedsImmovableCode());
   return new_object;
 }
 
 
+void CodeStub::VerifyPlatformFeatures(Isolate* isolate) {
+  ASSERT(CpuFeatures::VerifyCrossCompiling());
+}
+
+
 Handle<Code> CodeStub::GetCode(Isolate* isolate) {
   Factory* factory = isolate->factory();
   Heap* heap = isolate->heap();
   Code* code;
   if (UseSpecialCache()
       ? FindCodeInSpecialCache(&code, isolate)
       : FindCodeInCache(&code, isolate)) {
     ASSERT(IsPregenerated(isolate) == code->is_pregenerated());
     ASSERT(GetCodeKind() == code->kind());
     return Handle<Code>(code);
   }
 
+#ifdef DEBUG
+  VerifyPlatformFeatures(isolate);
+#endif
+
   {
     HandleScope scope(isolate);
 
     Handle<Code> new_object = GenerateCode(isolate);
     new_object->set_major_key(MajorKey());
     FinishCode(new_object);
     RecordCodeGeneration(*new_object, isolate);
 
 #ifdef ENABLE_DISASSEMBLER
     if (FLAG_print_code_stubs) {
@@ skipping 136 matching lines @@
   for (unsigned i = 0; i < ARRAY_SIZE(binop); i++) {
     BinaryOpStub stub(UNINITIALIZED);
     stub.op_ = binop[i];
     stub.GetCode(isolate);
   }
 
   // TODO(olivf) We should investigate why adding stubs to the snapshot is so
   // expensive at runtime. When solved we should be able to add most binops to
   // the snapshot instead of hand-picking them.
   // Generated list of commonly used stubs
-  Generate(Token::ADD, GENERIC, STRING, STRING, NO_OVERWRITE, isolate);
-  Generate(Token::ADD, GENERIC, STRING, STRING, OVERWRITE_RIGHT, isolate);
   Generate(Token::ADD, INT32, INT32, INT32, NO_OVERWRITE, isolate);
   Generate(Token::ADD, INT32, INT32, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, INT32, INT32, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::ADD, INT32, INT32, NUMBER, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, INT32, NUMBER, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::ADD, INT32, NUMBER, NUMBER, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, INT32, NUMBER, NUMBER, OVERWRITE_RIGHT, isolate);
   Generate(Token::ADD, INT32, SMI, INT32, NO_OVERWRITE, isolate);
   Generate(Token::ADD, INT32, SMI, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, INT32, SMI, INT32, OVERWRITE_RIGHT, isolate);
   Generate(Token::ADD, NUMBER, INT32, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::ADD, NUMBER, INT32, NUMBER, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, NUMBER, INT32, NUMBER, OVERWRITE_RIGHT, isolate);
   Generate(Token::ADD, NUMBER, NUMBER, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::ADD, NUMBER, NUMBER, NUMBER, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, NUMBER, NUMBER, NUMBER, OVERWRITE_RIGHT, isolate);
   Generate(Token::ADD, NUMBER, SMI, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::ADD, NUMBER, SMI, NUMBER, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, NUMBER, SMI, NUMBER, OVERWRITE_RIGHT, isolate);
   Generate(Token::ADD, SMI, INT32, INT32, NO_OVERWRITE, isolate);
   Generate(Token::ADD, SMI, INT32, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, SMI, INT32, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::ADD, SMI, NUMBER, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::ADD, SMI, NUMBER, NUMBER, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, SMI, NUMBER, NUMBER, OVERWRITE_RIGHT, isolate);
   Generate(Token::ADD, SMI, SMI, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::ADD, SMI, SMI, SMI, OVERWRITE_RIGHT, isolate);
-  Generate(Token::ADD, STRING, GENERIC, STRING, NO_OVERWRITE, isolate);
-  Generate(Token::ADD, STRING, GENERIC, STRING, OVERWRITE_LEFT, isolate);
-  Generate(Token::ADD, STRING, GENERIC, STRING, OVERWRITE_RIGHT, isolate);
-  Generate(Token::ADD, STRING, STRING, STRING, NO_OVERWRITE, isolate);
-  Generate(Token::ADD, STRING, STRING, STRING, OVERWRITE_LEFT, isolate);
-  Generate(Token::ADD, STRING, STRING, STRING, OVERWRITE_RIGHT, isolate);
   Generate(Token::BIT_AND, INT32, INT32, INT32, NO_OVERWRITE, isolate);
   Generate(Token::BIT_AND, INT32, INT32, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::BIT_AND, INT32, INT32, INT32, OVERWRITE_RIGHT, isolate);
   Generate(Token::BIT_AND, INT32, INT32, SMI, NO_OVERWRITE, isolate);
   Generate(Token::BIT_AND, INT32, INT32, SMI, OVERWRITE_RIGHT, isolate);
   Generate(Token::BIT_AND, INT32, SMI, INT32, NO_OVERWRITE, isolate);
   Generate(Token::BIT_AND, INT32, SMI, INT32, OVERWRITE_RIGHT, isolate);
   Generate(Token::BIT_AND, INT32, SMI, SMI, NO_OVERWRITE, isolate);
   Generate(Token::BIT_AND, INT32, SMI, SMI, OVERWRITE_LEFT, isolate);
   Generate(Token::BIT_AND, INT32, SMI, SMI, OVERWRITE_RIGHT, isolate);
@@ skipping 120 matching lines @@
   Generate(Token::SHL, SMI, SMI, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::SHL, SMI, SMI, INT32, OVERWRITE_RIGHT, isolate);
   Generate(Token::SHL, SMI, SMI, SMI, NO_OVERWRITE, isolate);
   Generate(Token::SHL, SMI, SMI, SMI, OVERWRITE_LEFT, isolate);
   Generate(Token::SHL, SMI, SMI, SMI, OVERWRITE_RIGHT, isolate);
   Generate(Token::SHR, INT32, SMI, SMI, NO_OVERWRITE, isolate);
   Generate(Token::SHR, INT32, SMI, SMI, OVERWRITE_LEFT, isolate);
   Generate(Token::SHR, INT32, SMI, SMI, OVERWRITE_RIGHT, isolate);
   Generate(Token::SHR, NUMBER, SMI, SMI, NO_OVERWRITE, isolate);
   Generate(Token::SHR, NUMBER, SMI, SMI, OVERWRITE_LEFT, isolate);
+  Generate(Token::SHR, NUMBER, SMI, INT32, OVERWRITE_RIGHT, isolate);
   Generate(Token::SHR, SMI, SMI, SMI, NO_OVERWRITE, isolate);
   Generate(Token::SHR, SMI, SMI, SMI, OVERWRITE_LEFT, isolate);
   Generate(Token::SHR, SMI, SMI, SMI, OVERWRITE_RIGHT, isolate);
   Generate(Token::SUB, INT32, INT32, INT32, NO_OVERWRITE, isolate);
   Generate(Token::SUB, INT32, INT32, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::SUB, INT32, NUMBER, NUMBER, NO_OVERWRITE, isolate);
   Generate(Token::SUB, INT32, NUMBER, NUMBER, OVERWRITE_RIGHT, isolate);
   Generate(Token::SUB, INT32, SMI, INT32, OVERWRITE_LEFT, isolate);
   Generate(Token::SUB, INT32, SMI, INT32, OVERWRITE_RIGHT, isolate);
   Generate(Token::SUB, NUMBER, INT32, NUMBER, NO_OVERWRITE, isolate);
@@ skipping 76 matching lines @@
       right->ToInt32(&value) && can_encode_arg_value(value) &&
       (left_state_ == SMI || left_state_ == INT32) &&
       (result_state_ == NONE || !fixed_right_arg_.has_value);
 
   fixed_right_arg_ = Maybe<int32_t>(new_has_fixed_right_arg, value);
 
   if (result.has_value) UpdateStatus(result.value, &result_state_);
 
   State max_input = Max(left_state_, right_state_);
 
-  // Avoid unnecessary Representation changes.
-  if (left_state_ == STRING && right_state_ < STRING) {
-    right_state_ = GENERIC;
-  } else if (right_state_ == STRING && left_state_ < STRING) {
-    left_state_ = GENERIC;
-  } else if ((right_state_ == GENERIC && left_state_ != STRING) ||
-             (left_state_ == GENERIC && right_state_ != STRING)) {
-    left_state_ = right_state_ = GENERIC;
-  } else if (!has_int_result() && op_ != Token::SHR &&
-             max_input <= NUMBER && max_input > result_state_) {
+  if (!has_int_result() && op_ != Token::SHR &&
+      max_input <= NUMBER && max_input > result_state_) {
     result_state_ = max_input;
   }
 
   ASSERT(result_state_ <= (has_int_result() ? INT32 : NUMBER) ||
          op_ == Token::ADD);
 
   if (old_state == GetExtraICState()) {
-    // Since the fpu is to precise, we might bail out on numbers which
-    // actually would truncate with 64 bit precision.
-    ASSERT(!CpuFeatures::IsSupported(SSE2) &&
-           result_state_ <= INT32);
-    result_state_ = NUMBER;
+    // Tagged operations can lead to non-truncating HChanges
+    if (left->IsUndefined() || left->IsBoolean()) {
+      left_state_ = GENERIC;
+    } else if (right->IsUndefined() || right->IsBoolean()) {
+      right_state_ = GENERIC;
+    } else {
+      // Since the fpu is to precise, we might bail out on numbers which
+      // actually would truncate with 64 bit precision.
+      ASSERT(!CpuFeatures::IsSupported(SSE2) &&
+             result_state_ <= INT32);
+      result_state_ = NUMBER;
+    }
   }
 }
 
 
 void BinaryOpStub::UpdateStatus(Handle<Object> object,
                                 State* state) {
+  bool is_truncating = (op_ == Token::BIT_AND || op_ == Token::BIT_OR ||
+                        op_ == Token::BIT_XOR || op_ == Token::SAR ||
+                        op_ == Token::SHL || op_ == Token::SHR);
   v8::internal::TypeInfo type = v8::internal::TypeInfo::FromValue(object);
+  if (object->IsBoolean() && is_truncating) {
+    // Booleans are converted by truncating by HChange.
+    type = TypeInfo::Integer32();
+  }
   if (object->IsUndefined()) {
     // Undefined will be automatically truncated for us by HChange.
-    type = (op_ == Token::BIT_AND || op_ == Token::BIT_OR ||
-            op_ == Token::BIT_XOR || op_ == Token::SAR ||
-            op_ == Token::SHL || op_ == Token::SHR)
-      ? TypeInfo::Integer32()
-      : TypeInfo::Double();
+    type = is_truncating ? TypeInfo::Integer32() : TypeInfo::Double();
   }
   State int_state = SmiValuesAre32Bits() ? NUMBER : INT32;
   State new_state = NONE;
   if (type.IsSmi()) {
     new_state = SMI;
   } else if (type.IsInteger32()) {
     new_state = int_state;
   } else if (type.IsNumber()) {
     new_state = NUMBER;
   } else if (object->IsString() && operation() == Token::ADD) {
@@ skipping 493 matching lines @@
 void ArrayConstructorStubBase::InstallDescriptors(Isolate* isolate) {
   ArrayNoArgumentConstructorStub stub1(GetInitialFastElementsKind());
   InstallDescriptor(isolate, &stub1);
   ArraySingleArgumentConstructorStub stub2(GetInitialFastElementsKind());
   InstallDescriptor(isolate, &stub2);
   ArrayNArgumentsConstructorStub stub3(GetInitialFastElementsKind());
   InstallDescriptor(isolate, &stub3);
 }
 
 
+void NumberToStringStub::InstallDescriptors(Isolate* isolate) {
+  NumberToStringStub stub;
+  InstallDescriptor(isolate, &stub);
+}
+
+
 void FastNewClosureStub::InstallDescriptors(Isolate* isolate) {
   FastNewClosureStub stub(STRICT_MODE, false);
   InstallDescriptor(isolate, &stub);
 }
 
 
 ArrayConstructorStub::ArrayConstructorStub(Isolate* isolate)
     : argument_count_(ANY) {
   ArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
 }
@@ skipping 23 matching lines @@
   InstallDescriptor(isolate, &stub3);
 }
 
 InternalArrayConstructorStub::InternalArrayConstructorStub(
     Isolate* isolate) {
   InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
 }
 
 
 } }  // namespace v8::internal