Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1334423002: win: Enable clang on Canary branch 2501. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
amineer_google, amineer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2501
Target Ref:
refs/pending/branch-heads/2501
Project:
chromium
Visibility:
Public.

Description

win: Enable clang on Canary branch 2501. This change does two things: 1. It sets the gyp variable "clang%" to 1 by default on Windows, letting the build use clang. 2. It changes DEPS to download the clang compiler unconditionally. (DEPS in src isn't used in release branches; the CL that actually does this is https://chromereviews.googleplex.com/252237013/) With these changes, the canary builder should download clang and then use it to build chrome/win on the 2501 branch without any bot config changes. The intent is to try to release one canary built with clang to find any issues this might have. BUG=82385 Committed: https://chromium.googlesource.com/chromium/src/+/bf276242dd0cd58b3e538015f1c18c1e18ff4bab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
This might do the trick. (I haven't tried doing a local build of that branch ...
5 years, 3 months ago (2015-09-11 18:52:23 UTC) #2
amineer_google
On 2015/09/11 18:52:23, Nico wrote: > This might do the trick. (I haven't tried doing ...
5 years, 3 months ago (2015-09-11 19:20:02 UTC) #3
Nico
On 2015/09/11 19:20:02, amineer wrote: > On 2015/09/11 18:52:23, Nico wrote: > > This might ...
5 years, 3 months ago (2015-09-11 19:31:00 UTC) #4
Nico
Committed patchset #1 (id:1) manually as bf276242dd0cd58b3e538015f1c18c1e18ff4bab (presubmit successful).
5 years, 3 months ago (2015-09-11 19:37:32 UTC) #5
scottmg
5 years, 3 months ago (2015-09-11 19:39:30 UTC) #6
Message was sent while issue was closed.
Exciting!

Powered by Google App Engine
This is Rietveld 408576698