Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334403002: [Sync] Add maxbogue to OWNERS for Android files. (Closed)

Created:
5 years, 3 months ago by maxbogue
Modified:
5 years, 3 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add maxbogue to OWNERS for Android files. Committed: https://crrev.com/bce3dfe804408281850fd58ee714591751138300 Cr-Commit-Position: refs/heads/master@{#348500}

Patch Set 1 #

Patch Set 2 : Add missing OWNERS file for tests. #

Total comments: 4

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/sync/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/android/javatests/src/org/chromium/chrome/browser/sync/OWNERS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/sync_shell/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sync/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M sync/android/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M sync/test/android/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
nyquist
https://codereview.chromium.org/1334403002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/OWNERS File chrome/android/javatests/src/org/chromium/chrome/browser/sync/OWNERS (right): https://codereview.chromium.org/1334403002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/OWNERS#newcode1 chrome/android/javatests/src/org/chromium/chrome/browser/sync/OWNERS:1: maxbogue@chromium.org Could you copy-paste this from //chrome/android/java/.../c/b/sync? (the file ...
5 years, 3 months ago (2015-09-11 19:16:12 UTC) #2
maxbogue
Nicolas and Tommy, PTAL! (A little late since Tommy already did, but oh well.) https://codereview.chromium.org/1334403002/diff/20001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/OWNERS ...
5 years, 3 months ago (2015-09-11 19:46:47 UTC) #4
Nicolas Zea
lgtm
5 years, 3 months ago (2015-09-11 20:48:43 UTC) #6
nyquist
lgtm
5 years, 3 months ago (2015-09-11 22:14:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334403002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334403002/40001
5 years, 3 months ago (2015-09-11 22:52:55 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-11 22:58:32 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/bce3dfe804408281850fd58ee714591751138300 Cr-Commit-Position: refs/heads/master@{#348500}
5 years, 3 months ago (2015-09-11 22:59:49 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:26:55 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bce3dfe804408281850fd58ee714591751138300
Cr-Commit-Position: refs/heads/master@{#348500}

Powered by Google App Engine
This is Rietveld 408576698