Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1334383002: Revert "Remove obsolete LTR scrollbar padding hack." (Closed)

Created:
5 years, 3 months ago by wkorman
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, szager1
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Remove obsolete LTR scrollbar padding hack." This reverts commit 0e054f07273d9f5104b4b3926dc438fa794436fe. Causes caret to disappear at edge of input fields in some situations. BUG=523969, 474759 Committed: https://crrev.com/2e65d3841eae75678d5438d3c82652d887d73baf git-svn-id: svn://svn.chromium.org/blink/trunk@202221 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : Layout test updates. #

Patch Set 3 : Merge changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -5 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
M LayoutTests/editing/input/editable-container-with-word-wrap-normal.html View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutBlockFlowLine.cpp View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
wkorman
Submitting and then reverting so that we can merge to M46 to follow merge request ...
5 years, 3 months ago (2015-09-11 18:03:17 UTC) #2
chrishtr
lgtm
5 years, 3 months ago (2015-09-11 18:05:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334383002/1
5 years, 3 months ago (2015-09-11 18:05:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334383002/20001
5 years, 3 months ago (2015-09-11 21:32:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/102163) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-11 21:51:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334383002/20001
5 years, 3 months ago (2015-09-11 22:25:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/103062)
5 years, 3 months ago (2015-09-11 22:40:47 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334383002/40001
5 years, 3 months ago (2015-09-14 17:28:07 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202221
5 years, 3 months ago (2015-09-14 19:03:56 UTC) #18
wkorman
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1347993002/ by wkorman@chromium.org. ...
5 years, 3 months ago (2015-09-16 03:51:52 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:35:17 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e65d3841eae75678d5438d3c82652d887d73baf

Powered by Google App Engine
This is Rietveld 408576698