Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2354)

Unified Diff: chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h

Issue 1334363002: [Eraser] First pass at removing the notification center panel. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
diff --git a/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h b/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
index 0d0b1dd82695f1fdeef4955be0d3ead7e679c401..3b5fa0799d72305b17c1fcdea52928613edbe744 100644
--- a/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
+++ b/chrome/browser/ui/cocoa/notifications/message_center_tray_bridge.h
@@ -16,8 +16,6 @@
#include "ui/message_center/message_center_tray_delegate.h"
@class MCPopupCollection;
-@class MCStatusItemView;
-@class MCTrayController;
namespace message_center {
class MessageCenter;
@@ -49,57 +47,15 @@ class MessageCenterTrayBridge :
private:
friend class MessageCenterTrayBridgeTest;
- // Updates the unread count on the status item.
- void UpdateStatusItem();
-
- // Opens the message center tray.
- void OpenTrayWindow();
-
- // Returns whether the status item allowed based on the preference value.
- bool CanShowStatusItem() const;
-
- // Returns whether the status item should be shown if allowed.
- bool NeedsStatusItem() const;
-
- // Constructs the status item view and registers its callback.
- void ShowStatusItem();
-
- // Destroys the status item view.
- void HideStatusItem();
-
- // Called after returning to the event loop from the
- // OnMessageCenterTrayChanged event to prevent multiple updates from being
- // rendered as the message center is modified.
- void HandleMessageCenterTrayChanged();
-
- // Notifies that the user has changed the show menubar item preference.
- void OnShowStatusItemChanged();
-
// The global, singleton message center model object. Weak.
message_center::MessageCenter* message_center_;
// C++ controller for the notification tray UI.
scoped_ptr<message_center::MessageCenterTray> tray_;
Robert Sesek 2015/09/15 22:07:08 I assume we still need |tray_| per the CL descript
dewittj 2015/09/15 22:52:22 I was assuming so, but now that I look it's only u
- // Obj-C window controller for the notification tray.
- base::scoped_nsobject<MCTrayController> tray_controller_;
-
- // View that is displayed on the system menu bar item.
- base::scoped_nsobject<MCStatusItemView> status_item_view_;
-
// Obj-C controller for the on-screen popup notifications.
base::scoped_nsobject<MCPopupCollection> popup_collection_;
- // Used to ensure only one status item update happens in a given call stack.
- bool status_item_update_pending_;
-
- // A PrefMember that calls OnShowStatusItemChanged when the pref is updated
- // by the user's selection in the main menu.
- BooleanPrefMember show_status_item_;
-
- // Weak pointer factory to posts tasks to self.
- base::WeakPtrFactory<MessageCenterTrayBridge> weak_ptr_factory_;
-
DISALLOW_COPY_AND_ASSIGN(MessageCenterTrayBridge);
};

Powered by Google App Engine
This is Rietveld 408576698