- Add getters for the current packageRoot or packageMap.

tests/standalone/io/platform_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import "dart:async";
 import "dart:io";
 import "dart:isolate";
 
 import "package:async_helper/async_helper.dart";
 import "package:expect/expect.dart";
 
-test() {
+test() async {
+  asyncStart();
   Expect.isTrue(Platform.numberOfProcessors > 0);
   var os = Platform.operatingSystem;
   Expect.isTrue(os == "android" || os == "linux" || os == "macos" ||
       os == "windows");
   Expect.equals(Platform.isLinux, Platform.operatingSystem == "linux");
   Expect.equals(Platform.isMacOS, Platform.operatingSystem == "macos");
   Expect.equals(Platform.isWindows, Platform.operatingSystem == "windows");
   Expect.equals(Platform.isAndroid, Platform.operatingSystem == "android");
   var sep = Platform.pathSeparator;
   Expect.isTrue(sep == '/' || (os == 'windows' && sep == '\\'));
@@ skipping 18 matching lines @@
     Expect.equals(Platform.resolvedExecutable.substring(1, 3), ':\\');
   }
   // Move directory to be sure script is correct.
   var oldDir = Directory.current;
   Directory.current = Directory.current.parent;
   Expect.isTrue(Platform.script.path.
                 endsWith('tests/standalone/io/platform_test.dart'));
   Expect.isTrue(Platform.script.toFilePath().startsWith(oldDir.path));
   // Restore dir.
   Directory.current = oldDir;
-  Directory packageRoot = new Directory(Platform.packageRoot);
+  String platformPackageRoot = (await Platform.packageRoot).toFilePath();

[Lasse Reichstein Nielsen, 2015/09/22 09:48:25]

. -> ?.

+  Directory packageRoot = new Directory(platformPackageRoot);
   Expect.isTrue(packageRoot.existsSync());
   Expect.isTrue(new Directory("${packageRoot.path}/expect").existsSync());
   Expect.isTrue(Platform.executableArguments.any(
-      (arg) => arg.contains(Platform.packageRoot)));
+      (arg) {
+        if (!arg.startsWith("--package-root=")) {
+          return false;
+        }
+        var commandPackageRoot = arg.replaceFirst("--package-root=", "");

[Lasse Reichstein Nielsen, 2015/09/22 09:48:25]

overkill :)

var argPackageRoot = "--package-root=";
if (!arg.startsWith(argPackageRoot)) return false;
var content = arg.substring(argPackageRoot.length);
return content == platformPackageRoot;

(or is the "endsWith" necessary?)

+        return platformPackageRoot.endsWith(commandPackageRoot);
+      }));
+  asyncEnd();
 }
 
-void f(reply) {
+f(reply) async {
   reply.send({"Platform.executable": Platform.executable,
               "Platform.script": Platform.script,
-              "Platform.packageRoot": Platform.packageRoot,
+              "Platform.packageRoot": (await Platform.packageRoot).toString(),
               "Platform.executableArguments": Platform.executableArguments});
 }
 
 testIsolate() {
   asyncStart();
   ReceivePort port = new ReceivePort();
   var remote = Isolate.spawn(f, port.sendPort);
-  port.first.then((results) {
+  port.first.then((results) async {
     Expect.equals(Platform.executable, results["Platform.executable"]);
 
     Uri uri = results["Platform.script"];
     // SpawnFunction retains the script url of the parent which in this
     // case was a relative path.
     Expect.equals("file", uri.scheme);
     Expect.isTrue(uri.path.endsWith('tests/standalone/io/platform_test.dart'));
-    Expect.equals(Platform.packageRoot, results["Platform.packageRoot"]);
+    var packageRoot = await Platform.packageRoot;
+    Expect.equals(packageRoot.toString(), results["Platform.packageRoot"]);
     Expect.listEquals(Platform.executableArguments,
                       results["Platform.executableArguments"]);
     asyncEnd();
   });
 }
 
 
 testVersion() {
   checkValidVersion(String version) {
     RegExp re = new RegExp(r'(\d+)\.(\d+)\.(\d+)(-dev\.([^\.]*)\.([^\.]*))?');
@@ skipping 44 matching lines @@
   Expect.throws(() => checkValidVersion('x.y.z'));
 }
 
 main() {
   // This tests assumes paths relative to dart main directory
   Directory.current = Platform.script.resolve('../../..').toFilePath();
   test();
   testIsolate();
   testVersion();
 }