Docserver: Support markdown for HTML content. Request thirdparty submission review.

Docserver: Support markdown for HTML content. Request thirdparty submission review.

R=kalman@chromium.org
BUG=293681
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244490

[hukun, 2014-01-10 07:46:20]

Hi source-third-party-reviews team,

I plan to submit one library called "markdown" into chromium/src/third_party.

Could you please help review?

Thanks
Kun HU

[not at google - send to devlin, 2014-01-10 18:36:21]

lgtm, what does open-source-third-party-reviews and/or I need to do?

[Daniel Berlin, 2014-01-11 07:22:22]

I'll take a look at it license wise/etc on monday


On Fri, Jan 10, 2014 at 10:36 AM, <kalman@chromium.org> wrote:

> lgtm, what does open-source-third-party-reviews and/or I need to do?
>
> https://codereview.chromium.org/133433002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[jschuh, 2014-01-11 17:09:31]

Where is this going to be used? Is it in a new web-facing service or is
output going to be shipping with Chrome somehow?

-j



On Fri, Jan 10, 2014 at 11:22 PM, Daniel Berlin <dannyb@google.com> wrote:

> I'll take a look at it license wise/etc on monday
>
>
> On Fri, Jan 10, 2014 at 10:36 AM, <kalman@chromium.org> wrote:
>
>> lgtm, what does open-source-third-party-reviews and/or I need to do?
>>
>> https://codereview.chromium.org/133433002/
>>
>
>  --
> --
> -----
> security@chromium.org is for discussing vulnerabilities and fixes in
> Chromium code.
> Please protect Chromium users: DO NOT FORWARD this email or disclose its
> contents to third parties.
>
> http://groups.google.com/a/chromium.org/group/security
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[hukun_google.com, 2014-01-13 06:53:44]

In my own understanding, it is used by
http://developer.chrome.com/apps/about_apps.html.

@Ben: do you have any other plan to use markdown in other places?


On Sun, Jan 12, 2014 at 1:09 AM, Justin Schuh <jschuh@chromium.org> wrote:

> Where is this going to be used? Is it in a new web-facing service or is
> output going to be shipping with Chrome somehow?
>
> -j
>
>
>
> On Fri, Jan 10, 2014 at 11:22 PM, Daniel Berlin <dannyb@google.com> wrote:
>
>> I'll take a look at it license wise/etc on monday
>>
>>
>> On Fri, Jan 10, 2014 at 10:36 AM, <kalman@chromium.org> wrote:
>>
>>> lgtm, what does open-source-third-party-reviews and/or I need to do?
>>>
>>> https://codereview.chromium.org/133433002/
>>>
>>
>>  --
>> --
>> -----
>> security@chromium.org is for discussing vulnerabilities and fixes in
>> Chromium code.
>> Please protect Chromium users: DO NOT FORWARD this email or disclose its
>> contents to third parties.
>>
>> http://groups.google.com/a/chromium.org/group/security
>>
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Daniel Berlin, 2014-01-13 07:13:57]

LGTM for open-source-third-party-reviews


On Sun, Jan 12, 2014 at 10:53 PM, Kun Hu <hukun@google.com> wrote:
> In my own understanding, it is used by
> http://developer.chrome.com/apps/about_apps.html.
>
> @Ben: do you have any other plan to use markdown in other places?
>
>
> On Sun, Jan 12, 2014 at 1:09 AM, Justin Schuh <jschuh@chromium.org> wrote:
>>
>> Where is this going to be used? Is it in a new web-facing service or is
>> output going to be shipping with Chrome somehow?
>>
>> -j
>>
>>
>>
>> On Fri, Jan 10, 2014 at 11:22 PM, Daniel Berlin <dannyb@google.com> wrote:
>>>
>>> I'll take a look at it license wise/etc on monday
>>>
>>>
>>> On Fri, Jan 10, 2014 at 10:36 AM, <kalman@chromium.org> wrote:
>>>>
>>>> lgtm, what does open-source-third-party-reviews and/or I need to do?
>>>>
>>>> https://codereview.chromium.org/133433002/
>>>
>>>
>>> --
>>> --
>>> -----
>>> security@chromium.org is for discussing vulnerabilities and fixes in
>>> Chromium code.
>>> Please protect Chromium users: DO NOT FORWARD this email or disclose its
>>> contents to third parties.
>>>
>>> http://groups.google.com/a/chromium.org/group/security
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-13 09:47:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hukun@chromium.org/133433002/90001

[commit-bot: I haz the power, 2014-01-13 12:10:50]

Change committed as 244490

[jschuh, 2014-01-13 14:27:04]

Why was this committed without getting security sign off?


On Mon, Jan 13, 2014 at 4:10 AM, <commit-bot@chromium.org> wrote:

> Change committed as 244490
>
>
> https://codereview.chromium.org/133433002/
>
> --
> --
> -----
> security@chromium.org is for discussing vulnerabilities and fixes in
> Chromium code.Please protect Chromium users: DO NOT FORWARD this email or
> disclose its contents to third parties.
>
> http://groups.google.com/a/chromium.org/group/security
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[not at google - send to devlin, 2014-01-13 21:35:02]

> Why was this committed without getting security sign off?

It's for inclusion in the documentation server (developer.chrome.com/extensions
and /apps), it doesn't affect chrome at all. Apologies if it was nonetheless
committed in error.

[jschuh, 2014-01-13 22:43:38]

Okay. I wouldn't block or revert this CL, but someone really should submit
a review ticket to ISE for the documentation server, since it's web-facing
and exposed to not entirely trusted content.


On Mon, Jan 13, 2014 at 1:35 PM, <kalman@chromium.org> wrote:

> Why was this committed without getting security sign off?
>>
>
> It's for inclusion in the documentation server (developer.chrome.com/
> extensions
> and /apps), it doesn't affect chrome at all. Apologies if it was
> nonetheless
> committed in error.
>
>
> https://codereview.chromium.org/133433002/
>
> --
> --
> -----
> security@chromium.org is for discussing vulnerabilities and fixes in
> Chromium code.Please protect Chromium users: DO NOT FORWARD this email or
> disclose its contents to third parties.
>
> http://groups.google.com/a/chromium.org/group/security
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[not at google - send to devlin, 2014-01-13 22:59:43]

On 2014/01/13 22:43:38, Justin Schuh wrote:
> Okay. I wouldn't block or revert this CL, but someone really should submit
> a review ticket to ISE for the documentation server, since it's web-facing
> and exposed to not entirely trusted content.
> 

The server went through an internal security review when it launched, about a
year ago I think.

[jschuh, 2014-01-13 23:37:36]

On 2014/01/13 22:59:43, kalman wrote:
> On 2014/01/13 22:43:38, Justin Schuh wrote:
> > Okay. I wouldn't block or revert this CL, but someone really should submit
> > a review ticket to ISE for the documentation server, since it's web-facing
> > and exposed to not entirely trusted content.
> > 
> 
> The server went through an internal security review when it launched, about a
> year ago I think.

But the code is changing. For example, this is a large, new dependency with
significant security implications.

[not at google - send to devlin, 2014-01-13 23:44:54]

> 
> But the code is changing. For example, this is a large, new dependency with
> significant security implications.

Fair enough, good idea.