Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1334303002: PPC: [builtins] Remove the weird STACK_OVERFLOW builtin. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] Remove the weird STACK_OVERFLOW builtin. Port 39604dda567b9ba9f4dcfe42f95471f30ec7cb6b Original commit message: Just use a %ThrowStackOverflow runtime function instead, which does the trick, especially since the Isolate already has a preallocated StackOverflow error for that. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/62ab109d188eeba7e941d731b63a3948d1c9353d Cr-Commit-Position: refs/heads/master@{#30697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/builtins-ppc.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334303002/1
5 years, 3 months ago (2015-09-11 14:25:15 UTC) #2
MTBrandyberry
5 years, 3 months ago (2015-09-11 14:28:42 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-11 14:54:21 UTC) #5
john.yan
lgtm
5 years, 3 months ago (2015-09-11 15:05:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334303002/1
5 years, 3 months ago (2015-09-11 15:06:22 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 15:08:53 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 15:09:11 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62ab109d188eeba7e941d731b63a3948d1c9353d
Cr-Commit-Position: refs/heads/master@{#30697}

Powered by Google App Engine
This is Rietveld 408576698