Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: build/common.gypi

Issue 1334273004: ios: Simplify -stdlib=libc++ logic. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index f7d2141a4ce7e02e8679e27e8d227cab6aad1294..6f8ede4bfbf07cbf90a61d7f9b1077d30e7ee4e7 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -513,10 +513,6 @@
# builds.
'use_custom_libcxx%': 0,
- # Use system libc++ instead of the default C++ library, usually libstdc++.
- # This is intended for iOS builds only.
- 'use_system_libcxx%': 0,
-
# Set to true to instrument the code with function call logger.
# See src/third_party/cygprofile/cyg-profile.cc for details.
'order_profiling%': 0,
@@ -874,7 +870,6 @@
'safe_browsing%': 0,
'enable_supervised_users%': 0,
'enable_task_manager%': 0,
- 'use_system_libcxx%': 1,
'enable_media_router%': 0,
}],
@@ -1198,7 +1193,6 @@
'use_instrumented_libraries%': '<(use_instrumented_libraries)',
'use_prebuilt_instrumented_libraries%': '<(use_prebuilt_instrumented_libraries)',
'use_custom_libcxx%': '<(use_custom_libcxx)',
- 'use_system_libcxx%': '<(use_system_libcxx)',
'order_profiling%': '<(order_profiling)',
'order_text_section%': '<(order_text_section)',
'enable_extensions%': '<(enable_extensions)',
@@ -5396,6 +5390,7 @@
'xcode_settings' : {
'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
'ENABLE_BITCODE': 'NO',
+ 'CLANG_CXX_LIBRARY': 'libc++', # -stdlib=libc++
'conditions': [
# Older Xcodes do not support -Wno-deprecated-register, so pass an
@@ -5426,20 +5421,6 @@
['target_subarch=="both"', {
'VALID_ARCHS': ['arm64', 'armv7', 'x86_64', 'i386'],
}],
- ['use_system_libcxx==1', {
- 'target_conditions': [
- # Only use libc++ when building target for iOS not when building
- # tools for the host (OS X) as Mac targets OS X SDK 10.6 which
- # does not support libc++.
- ['_toolset=="target"', {
- 'CLANG_CXX_LIBRARY': 'libc++', # -stdlib=libc++
- }]
- ],
- }, {
- # The default for deployment target of 7.0+ is libc++, so force
- # the old behavior unless libc++ is enabled.
- 'CLANG_CXX_LIBRARY': 'libstdc++', # -stdlib=libstdc++
- }],
],
},
'target_conditions': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698