Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1334273004: ios: Simplify -stdlib=libc++ logic. (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, stuartmorgan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ios: Simplify -stdlib=libc++ logic. We don't support building on 10.6 or with the 10.6 SDK any more, so it should be fine to always use libc++ unconditionally for iOS builds. No intended behavior change. BUG=366744, 402921 Committed: https://crrev.com/72fb7d90b3f09b537f118d6be4d2998f392e11a4 Cr-Commit-Position: refs/heads/master@{#348852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M build/common.gypi View 5 chunks +1 line, -20 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
5 years, 3 months ago (2015-09-14 21:52:08 UTC) #2
sdefresne
lgtm
5 years, 3 months ago (2015-09-15 08:50:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334273004/1
5 years, 3 months ago (2015-09-15 08:51:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 08:57:01 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72fb7d90b3f09b537f118d6be4d2998f392e11a4 Cr-Commit-Position: refs/heads/master@{#348852}
5 years, 3 months ago (2015-09-15 08:57:47 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:43:23 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72fb7d90b3f09b537f118d6be4d2998f392e11a4
Cr-Commit-Position: refs/heads/master@{#348852}

Powered by Google App Engine
This is Rietveld 408576698