Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334243004: Post DOMTimers on the corresponding LocalFrame's timer queue (Closed)

Created:
5 years, 3 months ago by Sami
Modified:
5 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-worker-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, falken, gavinp+loader_chromium.org, horo+watch_chromium.org, Nate Chapin, kinuko+worker_chromium.org, kinuko+watch, rwlbuis, sof, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Post DOMTimers on the corresponding LocalFrame's timer queue Each LocalFrame now has a WebFrameScheduler, with lazily created loading and timer queues. Currently all these queues share the same priority so the task execution order remains the same. However this patch makes it possible for the scheduler to take control later. One nice side effect of this patch is that it's now possible to see which origin DOMTimer tasks came from in tracing. Original patch by Alex Clarke <alexclarke@chromium.org>;. BUG=510398

Patch Set 1 #

Patch Set 2 : Page => FrameHost #

Patch Set 3 : Split out WebFrameHostScheduler changes. #

Patch Set 4 : Fixed layout test failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -5 lines) Patch
M Source/core/dom/Document.cpp View 1 2 5 chunks +6 lines, -0 lines 0 comments Download
M Source/core/frame/DOMTimer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/DOMTimer.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/frame/DOMTimerCoordinator.h View 1 2 4 chunks +7 lines, -1 line 0 comments Download
M Source/core/frame/DOMTimerCoordinator.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/frame/FrameHost.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M Source/core/frame/FrameHost.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.cpp View 1 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 2 3 chunks +23 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 2 chunks +8 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M Source/platform/Timer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/Timer.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
Sami
Follow-up to https://codereview.chromium.org/1348853002/. PTAL.
5 years, 3 months ago (2015-09-17 14:42:30 UTC) #2
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-18 08:36:22 UTC) #3 
lgtm

Powered by Google App Engine
This is Rietveld 408576698