pkg/compiler/lib/src/resolution/resolution.dart - Issue 1334203002: Compute Compiler.proxyConstant on demand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/resolution/resolution.dart

Issue 1334203002: Compute Compiler.proxyConstant on demand. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/resolution/resolution.dart

diff --git a/pkg/compiler/lib/src/resolution/resolution.dart b/pkg/compiler/lib/src/resolution/resolution.dart

index cf53b0854d66d23e99fb32d6640d878bb8e901d4..a137493de37b67c5f17566b53d42428d1a1f4b50 100644

--- a/pkg/compiler/lib/src/resolution/resolution.dart

+++ b/pkg/compiler/lib/src/resolution/resolution.dart

@@ -598,7 +598,7 @@ class ResolverTask extends CompilerTask {

metadata.ensureResolved(compiler);

ConstantValue value =

compiler.constants.getConstantValue(metadata.constant);

- if (!element.isProxy && value == compiler.proxyConstant) {

+ if (!element.isProxy && compiler.isProxyConstant(value)) {

element.isProxy = true;

}

« no previous file with comments | « pkg/compiler/lib/src/resolution/registry.dart ('k') | pkg/compiler/lib/src/ssa/codegen.dart » ('j') | no next file with comments »