Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13342002: Disable tcmalloc on nvidia GPU bots to work around hangs. (Closed)

Created:
7 years, 8 months ago by Paweł Hajdan Jr.
Modified:
7 years, 8 months ago
Reviewers:
cmp, Zhenyao Mo
CC:
chromium-reviews, cmp-cc_chromium.org
Visibility:
Public.

Description

Disable tcmalloc on nvidia GPU bots to work around hangs. BUG=188501, 177218 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191469

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M build/masters/master.chromium.gpu/master.cfg View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
7 years, 8 months ago (2013-03-29 20:48:21 UTC) #1
Zhenyao Mo
On 2013/03/29 20:48:21, Paweł Hajdan Jr. wrote: LGTM
7 years, 8 months ago (2013-03-29 22:09:16 UTC) #2
cmp
lgtm with nits https://codereview.chromium.org/13342002/diff/1/build/masters/master.chromium.gpu/master.cfg File build/masters/master.chromium.gpu/master.cfg (right): https://codereview.chromium.org/13342002/diff/1/build/masters/master.chromium.gpu/master.cfg#newcode273 build/masters/master.chromium.gpu/master.cfg:273: 'GYP_DEFINES': 'fastbuild=1 internal_gles2_conform_tests=1 linux_use_tcmalloc=0', nit: 80 ...
7 years, 8 months ago (2013-03-29 23:01:12 UTC) #3
Paweł Hajdan Jr.
https://codereview.chromium.org/13342002/diff/1/build/masters/master.chromium.gpu/master.cfg File build/masters/master.chromium.gpu/master.cfg (right): https://codereview.chromium.org/13342002/diff/1/build/masters/master.chromium.gpu/master.cfg#newcode273 build/masters/master.chromium.gpu/master.cfg:273: 'GYP_DEFINES': 'fastbuild=1 internal_gles2_conform_tests=1 linux_use_tcmalloc=0', On 2013/03/29 23:01:12, cmp wrote: ...
7 years, 8 months ago (2013-03-29 23:33:04 UTC) #4
Paweł Hajdan Jr.
7 years, 8 months ago (2013-03-29 23:35:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 manually as r191469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698