Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1334153004: X87: [Interpreter] Add support for JS calls. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Add support for JS calls. port e7fb233946b990ecbbbd76cc6529f62bd5da64e3 (r30710). original commit message: Adds support for JS calls to the interpreter. In order to support calls from the interpreter, the PushArgsAndCall builtin is added which pushes a sequence of arguments onto the stack and calls builtin::Call. Adds the Call bytecode. BUG= Committed: https://crrev.com/2b476800e19f3455672002acdfe3299689df4d3f Cr-Commit-Position: refs/heads/master@{#30745}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M src/x87/builtins-x87.cc View 1 chunk +35 lines, -0 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-15 10:16:05 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-15 10:50:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334153004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334153004/1
5 years, 3 months ago (2015-09-15 10:50:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 12:24:53 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 12:25:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b476800e19f3455672002acdfe3299689df4d3f
Cr-Commit-Position: refs/heads/master@{#30745}

Powered by Google App Engine
This is Rietveld 408576698