Issue 1334153002: Allow direct and indirect navigation values to be varied via field trial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1334153002: Allow direct and indirect navigation values to be varied via field trial. (Closed)

Created:
5 years, 3 months ago by Sam McNally

Modified:
5 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

More Reviews

Description

Allow direct and indirect navigation values to be varied via field trial. This CL allows the engagement scores assigned to direct and indirect navigations to be varied via a field trial. It also makes method names related to the setting of values in AppBannerSettingsHelper more consistent. BUG=487519 Review URL: https://codereview.chromium.org/1309803005 Cr-Commit-Position: refs/heads/master@{#345729} (cherry picked from commit 633bbe04d2525d7272a78d78f8e3fdd0abe4d5a2) Committed: https://chromium.googlesource.com/chromium/src/+/520171cb2a4ecaa08ff5802c0d190870a60be2ef

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -29 lines)			Patch
M	chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java	View	2 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/android/banners/app_banner_manager_android.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/banners/app_banner_manager.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/banners/app_banner_manager.cc	View	3 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/banners/app_banner_settings_helper.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/banners/app_banner_settings_helper.cc	View	4 chunks	+48 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Sam McNally

5 years, 3 months ago (2015-09-11 06:21:07 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
520171cb2a4ecaa08ff5802c0d190870a60be2ef.

Expand Messages | Collapse Messages