Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1334113003: Remove unused constructor parameter from net::WebSocket. (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
dgozman, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused constructor parameter from net::WebSocket. net::WebSocket has "pos" constructor parameter which is never used. This CL removes the parameter as a refactoring. BUG=523228 Committed: https://crrev.com/1dea7d0be721babaa2e9e7f7f19862277510718d Cr-Commit-Position: refs/heads/master@{#349321}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M net/server/http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/server/web_socket.h View 2 chunks +2 lines, -4 lines 0 comments Download
M net/server/web_socket.cc View 3 chunks +3 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (4 generated)
yhirano
5 years, 3 months ago (2015-09-11 07:09:24 UTC) #2
mmenke
LGTM
5 years, 3 months ago (2015-09-11 14:05:36 UTC) #3
yhirano
dgozman@, do you have any comments?
5 years, 3 months ago (2015-09-16 18:24:07 UTC) #4
dgozman
lgtm
5 years, 3 months ago (2015-09-16 18:27:12 UTC) #5
yhirano
Thanks!
5 years, 3 months ago (2015-09-16 18:35:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334113003/20001
5 years, 3 months ago (2015-09-16 18:36:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/113878)
5 years, 3 months ago (2015-09-16 19:37:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334113003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334113003/20001
5 years, 3 months ago (2015-09-17 00:37:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 02:11:05 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 02:11:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1dea7d0be721babaa2e9e7f7f19862277510718d
Cr-Commit-Position: refs/heads/master@{#349321}

Powered by Google App Engine
This is Rietveld 408576698