Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334043003: Use int64 to store time.Time internally in memory implementation. (Closed)

Created:
5 years, 3 months ago by Vadim Sh.
Modified:
5 years, 3 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Use int64 to store time.Time internally in memory implementation. Uint64 causes overflow when storing zero time.Time{} (that due to some Go stubborn weirdness is represented by negative timestamp). R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/829de51b404773a421e6f39b09cd8ccd2027d392

Patch Set 1 #

Patch Set 2 : test that IsZero #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : remove debug panic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M impl/memory/datastore_test.go View 1 2 2 chunks +22 lines, -0 lines 0 comments Download
M service/datastore/serialize/serialize.go View 1 chunk +3 lines, -3 lines 0 comments Download
M service/datastore/serialize/serialize_test.go View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Vadim Sh.
5 years, 3 months ago (2015-09-15 02:29:08 UTC) #1
iannucci
lgtm https://codereview.chromium.org/1334043003/diff/20001/impl/memory/datastore_test.go File impl/memory/datastore_test.go (right): https://codereview.chromium.org/1334043003/diff/20001/impl/memory/datastore_test.go#newcode535 impl/memory/datastore_test.go:535: func TestDefaultTimeField(t *testing.T) { this is fine, but ...
5 years, 3 months ago (2015-09-15 02:35:06 UTC) #2
Vadim Sh.
https://codereview.chromium.org/1334043003/diff/20001/impl/memory/datastore_test.go File impl/memory/datastore_test.go (right): https://codereview.chromium.org/1334043003/diff/20001/impl/memory/datastore_test.go#newcode535 impl/memory/datastore_test.go:535: func TestDefaultTimeField(t *testing.T) { On 2015/09/15 02:35:06, iannucci wrote: ...
5 years, 3 months ago (2015-09-15 03:01:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334043003/40002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334043003/40002
5 years, 3 months ago (2015-09-15 03:04:04 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 03:05:30 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:40002) as
https://github.com/luci/gae/commit/829de51b404773a421e6f39b09cd8ccd2027d392

Powered by Google App Engine
This is Rietveld 408576698