Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1334033004: formalize generate->bitmap (Closed)

Created:
5 years, 3 months ago by reed2
Modified:
5 years, 3 months ago
Reviewers:
hal.canary, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

formalize generate->bitmap just move block of code to expose it BUG=skia:4328 TBR= Committed: https://skia.googlesource.com/skia/+/4d5b67637bf79dceff23d3ba95ee7ff6f1e77966

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -39 lines) Patch
M include/core/SkImageGenerator.h View 2 chunks +19 lines, -0 lines 0 comments Download
M src/core/SkImageCacherator.cpp View 1 chunk +2 lines, -38 lines 0 comments Download
M src/core/SkImageGenerator.cpp View 1 chunk +40 lines, -0 lines 0 comments Download
M tools/Resources.cpp View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 10 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334033004/1
5 years, 3 months ago (2015-09-13 16:52:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1334033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1334033004/1
5 years, 3 months ago (2015-09-13 17:03:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/4d5b67637bf79dceff23d3ba95ee7ff6f1e77966
5 years, 3 months ago (2015-09-13 18:03:36 UTC) #6
hal.canary
https://codereview.chromium.org/1334033004/diff/1/tools/Resources.cpp File tools/Resources.cpp (right): https://codereview.chromium.org/1334033004/diff/1/tools/Resources.cpp#newcode32 tools/Resources.cpp:32: return gen && gen->tryGenerateBitmap(dst); this no longer exercises discardable ...
5 years, 3 months ago (2015-09-24 20:18:10 UTC) #8
reed1
5 years, 3 months ago (2015-09-25 08:05:17 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1334033004/diff/1/tools/Resources.cpp
File tools/Resources.cpp (right):

https://codereview.chromium.org/1334033004/diff/1/tools/Resources.cpp#newcode32
tools/Resources.cpp:32: return gen && gen->tryGenerateBitmap(dst);
On 2015/09/24 20:18:10, Hal Canary wrote:
> this no longer exercises discardable memory!

Yes, discardable bitmaps is a deprecated feature. Use images to get that
feature.

Powered by Google App Engine
This is Rietveld 408576698