Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: components/web_view/web_view_impl.cc

Issue 1333963003: mandoline: Set up WebViewTest and add a basic test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix gn check. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/web_view/web_view_impl.cc
diff --git a/components/web_view/web_view_impl.cc b/components/web_view/web_view_impl.cc
index 9d04651edc6d0395fb20e659b340f071883c113c..367a406d00cc9ce26847016be78e95089cb60023 100644
--- a/components/web_view/web_view_impl.cc
+++ b/components/web_view/web_view_impl.cc
@@ -44,6 +44,7 @@ WebViewImpl::WebViewImpl(mojo::ApplicationImpl* app,
}
WebViewImpl::~WebViewImpl() {
+ pending_load_.reset();
sky 2015/09/10 22:09:30 Document why you need to do this.
Elliot Glaysher 2015/09/10 22:32:35 Turned out to not need this...after the changes to
if (content_)
content_->RemoveObserver(this);
if (root_) {

Powered by Google App Engine
This is Rietveld 408576698