Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1333963003: mandoline: Set up WebViewTest and add a basic test. (Closed)

Created:
5 years, 3 months ago by Elliot Glaysher
Modified:
5 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Set up WebViewTest and add a basic test. BUG=526268 Committed: https://crrev.com/6728d93826ddb3b2d6def0939544f539f9b8fa46 Cr-Commit-Position: refs/heads/master@{#348422}

Patch Set 1 #

Patch Set 2 : Fix args flags for x11 #

Patch Set 3 : Use mojo's copy of utils instead of net #

Patch Set 4 : Fix gn check. #

Total comments: 5

Patch Set 5 : sky comments #

Total comments: 1

Patch Set 6 : Reverse ths stuff. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -1 line) Patch
A components/test/data/web_view/test_title_changed.html View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/web_view/BUILD.gn View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M components/web_view/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A components/web_view/web_view_apptest.cc View 1 2 3 4 5 1 chunk +111 lines, -0 lines 0 comments Download
M mojo/tools/data/apptests View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Elliot Glaysher
I've carved this out from the back/forward patch. The test here is fairly trivial, but ...
5 years, 3 months ago (2015-09-10 21:44:33 UTC) #2
sky
https://codereview.chromium.org/1333963003/diff/60001/components/web_view/test/data/test_title_changed.html File components/web_view/test/data/test_title_changed.html (right): https://codereview.chromium.org/1333963003/diff/60001/components/web_view/test/data/test_title_changed.html#newcode1 components/web_view/test/data/test_title_changed.html:1: <html><title>Test Title Changed</title></html> It seems as though we're putting ...
5 years, 3 months ago (2015-09-10 22:09:30 UTC) #3
Elliot Glaysher
ptal https://codereview.chromium.org/1333963003/diff/60001/components/web_view/web_view_impl.cc File components/web_view/web_view_impl.cc (right): https://codereview.chromium.org/1333963003/diff/60001/components/web_view/web_view_impl.cc#newcode47 components/web_view/web_view_impl.cc:47: pending_load_.reset(); On 2015/09/10 22:09:30, sky wrote: > Document ...
5 years, 3 months ago (2015-09-10 22:32:36 UTC) #4
sky
LGTM https://codereview.chromium.org/1333963003/diff/80001/components/web_view/web_view_apptest.cc File components/web_view/web_view_apptest.cc (right): https://codereview.chromium.org/1333963003/diff/80001/components/web_view/web_view_apptest.cc#newcode108 components/web_view/web_view_apptest.cc:108: EXPECT_EQ(last_title(), "Test Title Changed"); nit: expected, actual.
5 years, 3 months ago (2015-09-10 23:51:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333963003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333963003/100001
5 years, 3 months ago (2015-09-11 00:33:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/105710)
5 years, 3 months ago (2015-09-11 02:33:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333963003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333963003/100001
5 years, 3 months ago (2015-09-11 17:03:42 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 3 months ago (2015-09-11 17:34:32 UTC) #13
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/6728d93826ddb3b2d6def0939544f539f9b8fa46 Cr-Commit-Position: refs/heads/master@{#348422}
5 years, 3 months ago (2015-09-11 17:35:10 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:23:34 UTC) #15
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/6728d93826ddb3b2d6def0939544f539f9b8fa46
Cr-Commit-Position: refs/heads/master@{#348422}

Powered by Google App Engine
This is Rietveld 408576698