Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1333963002: Optionally use new GN optimization config. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Optionally use new GN optimization config. The GN default optimization flag is changing from being specific to the debug/release status of the build to always being "default_optimization" so it's easier to override without being conditional on the exact setup in BUILDCONFIG.gn. See https://codereview.chromium.org/1324623005/ Since V8 is DEPS-ed in, it will need to support both modes to allow a landing. This patch uses a temporary transitional flag I added to BUILDCONFIG to indicate which variant should be used. After the patch is landed, we can remove the new conditions and just remove default_optimization. Committed: https://crrev.com/ea8cfa929fcd90975039cb037e7547bf75d7aec9 Cr-Commit-Position: refs/heads/master@{#30703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M BUILD.gn View 3 chunks +15 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
brettw
Please puch CQ button if it looks good. Thanks!
5 years, 3 months ago (2015-09-10 17:54:13 UTC) #3
brettw
Please puch CQ button if it looks good. Thanks!
5 years, 3 months ago (2015-09-10 17:54:13 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-11 17:34:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1333963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1333963002/1
5 years, 3 months ago (2015-09-11 17:34:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 18:28:23 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 18:28:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea8cfa929fcd90975039cb037e7547bf75d7aec9
Cr-Commit-Position: refs/heads/master@{#30703}

Powered by Google App Engine
This is Rietveld 408576698