Issue 133393003: Revert "Remove flags argument from EmitCallWithStub" and corresponding MIPS CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133393003: Revert "Remove flags argument from EmitCallWithStub" and corresponding MIPS CL (Closed)

Created:
6 years, 11 months ago by Michael Achenbach

Modified:
6 years, 11 months ago

Reviewers:
Paul Lind, Toon Verwaest, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Remove flags argument from EmitCallWithStub" and "MIPS: Remove flags argument from EmitCallWithStub." This reverts commits r18598 and r18604 for breaking GC stress. BUG= TBR=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18606

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -21 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/full-codegen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	4 chunks	+6 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

Committed patchset #1 manually as r18606 (presubmit successful).

6 years, 11 months ago (2014-01-15 08:12:46 UTC) #2

Message was sent while issue was closed.

rubberstamp LGTM