Source/core/dom/Node.cpp - Issue 133393002: Make ancestors of modal <dialog> inert

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Node.cpp

Issue 133393002: Make ancestors of modal <dialog> inert (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: save a tree walk if able Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Node.cpp

diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp

index 39c1c7e0b6e200cad91a51bc9fc980174a3df429..e46cbab9413e30a2ec5a4e428dcf01336c02b1f7 100644

--- a/Source/core/dom/Node.cpp

+++ b/Source/core/dom/Node.cpp

@@ -798,7 +798,7 @@ bool Node::shouldHaveFocusAppearance() const

bool Node::isInert() const

{

const HTMLDialogElement* dialog = document().activeModalDialog();

- if (dialog && !containsIncludingShadowDOM(dialog) && !dialog->containsIncludingShadowDOM(this))

+ if (dialog && this != document() && !dialog->containsIncludingShadowDOM(this))

return true;

return document().ownerElement() && document().ownerElement()->isInert();

}