Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 133393002: Make ancestors of modal <dialog> inert (Closed)

Created:
6 years, 11 months ago by falken
Modified:
6 years, 11 months ago
Reviewers:
esprehn
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive, dominicc (has gone to gerrit), dmazzoni
Visibility:
Public.

Description

Make ancestors of modal <dialog> inert As per spec change: http://html5.org/r/8343 Now, document.body is also inert. Previously events that "skipped" an inert node were fired on document.body; now, they are fired on document. Test: modal-dialog-ancestor-is-inert.html Also, other tests cover some of this behavior and have expectations updated. BUG=329407 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165040

Patch Set 1 #

Patch Set 2 : add layout test #

Patch Set 3 : save a tree walk if able #

Total comments: 2

Patch Set 4 : move some expandos to window #

Messages

Total messages: 7 (0 generated)
falken
Elliott, could you review please?
6 years, 11 months ago (2014-01-10 11:45:05 UTC) #1
esprehn
lgtm https://codereview.chromium.org/133393002/diff/60001/LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html File LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html (right): https://codereview.chromium.org/133393002/diff/60001/LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html#newcode81 LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html:81: document.expectedEventCount = events.length - 1; // document won't ...
6 years, 11 months ago (2014-01-14 01:43:29 UTC) #2
falken
https://codereview.chromium.org/133393002/diff/60001/LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html File LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html (right): https://codereview.chromium.org/133393002/diff/60001/LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html#newcode81 LayoutTests/fast/dom/HTMLDialogElement/modal-dialog-blocks-mouse-events.html:81: document.expectedEventCount = events.length - 1; // document won't get ...
6 years, 11 months ago (2014-01-14 01:50:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/133393002/220001
6 years, 11 months ago (2014-01-14 04:50:17 UTC) #4
commit-bot: I haz the power
Change committed as 165040
6 years, 11 months ago (2014-01-14 08:09:10 UTC) #5
tdanderson
A revert of this CL has been created in https://codereview.chromium.org/138183003/ by tdanderson@chromium.org. The reason for ...
6 years, 11 months ago (2014-01-14 18:24:30 UTC) #6
falken
6 years, 11 months ago (2014-01-15 01:18:40 UTC) #7
Message was sent while issue was closed.
On 2014/01/14 18:24:30, tdanderson wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/138183003/ by mailto:tdanderson@chromium.org.
> 
> The reason for reverting is: This patch is the most probable cause of the
> failing content_browsertests:
> 
> AccessibilityModalDialogInIframeOpened
> AccessibilityModalDialogOpened
> AccessibilityModalDialogStack
> 
> See:
> 
> http://build.chromium.org/p/chromium.webkit/builders/Win7%2520Tests/builds/529
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Win7%2520%2528dbg%2529/b...
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Mac10.6%2520Tests/builds...
> 
>
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%2520Tests/builds...
> 
> I could not reach the patch author on IRC due to the time zone difference..

Sorry, I forgot these tests will need new expectations. This will have to be a
3-sided patch.

Powered by Google App Engine
This is Rietveld 408576698