Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 13339: Experimental: thread the virtual frame through the deferred code... (Closed)

Created:
12 years ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Experimental: thread the virtual frame through the deferred code generated at the end of functions. It is piggybacked on the jump target infrastructure pairing the label of a block with the epected frame on entry. This is simple and works for now but eventually we want to get the code to make a frame mergable off the fast path or do away with it completely. The inlined code for the smi part of binary operations is duplicated, but that is a temporary situation. Committed: http://code.google.com/p/v8/source/detail?r=957

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -40 lines) Patch
M src/codegen.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/codegen.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M src/codegen-ia32.cc View 16 chunks +193 lines, -31 lines 3 comments Download
M src/macro-assembler-ia32.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/macro-assembler-ia32.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Chromium)
12 years ago (2008-12-10 09:58:51 UTC) #1
Mads Ager (chromium)
LGTM
12 years ago (2008-12-10 11:48:23 UTC) #2
William Hesse
Looks good to me, with one comment. http://codereview.chromium.org/13339/diff/1/6 File src/codegen-ia32.cc (right): http://codereview.chromium.org/13339/diff/1/6#newcode708 Line 708: void ...
12 years ago (2008-12-10 12:02:51 UTC) #3
Kevin Millikin (Chromium)
12 years ago (2008-12-10 12:09:50 UTC) #4
http://codereview.chromium.org/13339/diff/1/6
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/13339/diff/1/6#newcode708
Line 708: void GenerateInlineCode();
On 2008/12/10 12:02:51, William Hesse wrote:
> Where is this function now defined?  Or is it dead?

Not dead, we call it in the generic binary operation.  It's a clone of
GenericBinaryOpStub::GenerateSmiCode, so I defined them together to emphasize
that fact.

http://codereview.chromium.org/13339/diff/1/6#newcode4386
Line 4386: void DeferredInlineBinaryOperation::GenerateInlineCode() {
...is defined right here.

Powered by Google App Engine
This is Rietveld 408576698