content/browser/tracing/tracing_controller_impl.h - Issue 1333873002: [tracing] Fix MemoryDumpManager to support startup tracing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tracing/tracing_controller_impl.h

Issue 1333873002: [tracing] Fix MemoryDumpManager to support startup tracing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re dsinclair #5 (nits, invert Initialize args) Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/tracing/tracing_controller_impl.h

diff --git a/content/browser/tracing/tracing_controller_impl.h b/content/browser/tracing/tracing_controller_impl.h

index ad6126acea759c72e8dec96df44ad3fe0338b780..9af728ef0697814cd07c1665c5389c40ddfac484 100644

--- a/content/browser/tracing/tracing_controller_impl.h

+++ b/content/browser/tracing/tracing_controller_impl.h

@@ -59,7 +59,6 @@ class TracingControllerImpl

void RequestGlobalMemoryDump(

const base::trace_event::MemoryDumpRequestArgs& args,

const base::trace_event::MemoryDumpCallback& callback) override;

- bool IsCoordinatorProcess() const override;

uint64 GetTracingProcessId() const override;

class TraceMessageFilterObserver {

« no previous file with comments | « content/browser/tracing/memory_tracing_browsertest.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »