Source/bindings/scripts/v8_methods.py - Issue 1333853002: bindings: Moves event handlers and methods of Window to the instance object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_methods.py

Issue 1333853002: bindings: Moves event handlers and methods of Window to the instance object. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Synced. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_methods.py

diff --git a/Source/bindings/scripts/v8_methods.py b/Source/bindings/scripts/v8_methods.py

index 7b7c0cc25848acbd0568344f430a70b3d3970c10..7585823b7c92a2db63ec052631dd4c7bd8c699de 100644

--- a/Source/bindings/scripts/v8_methods.py

+++ b/Source/bindings/scripts/v8_methods.py

@@ -405,7 +405,7 @@ def v8_value_to_local_cpp_value(method, argument, index, return_promise=False, r

# Auxiliary functions

################################################################################

-# [NotEnumerable]

+# [NotEnumerable], [Unforgeable]

def property_attributes(interface, method):

extended_attributes = method.extended_attributes

property_attributes_list = []

@@ -413,8 +413,7 @@ def property_attributes(interface, method):

property_attributes_list.append('v8::DontEnum')

if is_unforgeable(interface, method):

property_attributes_list.append('v8::ReadOnly')

- if property_attributes_list:

- property_attributes_list.insert(0, 'v8::DontDelete')

+ property_attributes_list.append('v8::DontDelete')

return property_attributes_list

« no previous file with comments | « LayoutTests/webexposed/resources/global-interface-listing.js ('k') | Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »