src/compiler/linkage.h - Issue 1333843002: [runtime] Move binary operator fallbacks into the runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/linkage.h

Issue 1333843002: [runtime] Move binary operator fallbacks into the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: No need for frame states in bytecode handlers. Add test case. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/linkage.h

diff --git a/src/compiler/linkage.h b/src/compiler/linkage.h

index 57203627887647cbaa1736d45292054d121adbbe..b25fe413c96c40f69fa5a1e942bb3b2f9aa08644 100644

--- a/src/compiler/linkage.h

+++ b/src/compiler/linkage.h

@@ -273,7 +273,7 @@ class Linkage : public ZoneObject {

CallDescriptor::Flags flags);

static CallDescriptor* GetRuntimeCallDescriptor(

Zone* zone, Runtime::FunctionId function, int parameter_count,

- Operator::Properties properties);

+ Operator::Properties properties, bool needs_frame_state = true);

rmcilroy 2015/09/10 11:16:34 nit - could you make this an enum instead of a boo

Benedikt Meurer 2015/09/10 11:26:51 Mhm, I think that is a bit overkill for the one ca

static CallDescriptor* GetStubCallDescriptor(

Isolate* isolate, Zone* zone, const CallInterfaceDescriptor& descriptor,

« no previous file with comments | « src/compiler/interpreter-assembler.cc ('k') | src/compiler/linkage.cc » ('j') | src/hydrogen.cc » ('J')