[runtime] Move binary operator fallbacks into the runtime.

test/unittests/compiler/interpreter-assembler-unittest.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "test/unittests/compiler/interpreter-assembler-unittest.h"
 
 #include "src/compiler/graph.h"
 #include "src/compiler/node.h"
 #include "src/interface-descriptors.h"
 #include "src/isolate.h"
@@ skipping 309 matching lines @@
     InterpreterAssemblerForTest m(this, bytecode);
     Node* object = m.IntPtrConstant(0xdeadbeef);
     int offset = 16;
     Node* load_field = m.LoadObjectField(object, offset);
     EXPECT_THAT(load_field,
                 m.IsLoad(kMachAnyTagged, object,
                          IsIntPtrConstant(offset - kHeapObjectTag)));
   }
 }
 
 

[rmcilroy, 2015/09/10 10:28:25]

Please add a CallRuntime test here 

[Benedikt Meurer, 2015/09/10 10:55:49]

Done.

-TARGET_TEST_F(InterpreterAssemblerTest, CallJSBuiltin) {
-  TRACED_FOREACH(interpreter::Bytecode, bytecode, kBytecodes) {
-    InterpreterAssemblerForTest m(this, bytecode);
-    Node* receiver = m.IntPtrConstant(1234);
-    Node* call_js_builtin_0 =
-        m.CallJSBuiltin(Context::SUB_BUILTIN_INDEX, receiver);
-
-    Matcher<Node*> load_globals_matcher = m.IsLoad(
-        kMachAnyTagged, IsParameter(Linkage::kInterpreterContextParameter),
-        IsIntPtrConstant(Context::SlotOffset(Context::GLOBAL_OBJECT_INDEX)));
-    Matcher<Node*> load_native_context_matcher = m.IsLoad(
-        kMachAnyTagged, load_globals_matcher,
-        IsIntPtrConstant(GlobalObject::kNativeContextOffset - kHeapObjectTag));
-    Matcher<Node*> function_matcher = m.IsLoad(
-        kMachAnyTagged, load_native_context_matcher,
-        IsIntPtrConstant(Context::SlotOffset(Context::SUB_BUILTIN_INDEX)));
-    Matcher<Node*> context_matcher =
-        m.IsLoad(kMachAnyTagged, function_matcher,
-                 IsIntPtrConstant(JSFunction::kContextOffset - kHeapObjectTag));
-    EXPECT_THAT(call_js_builtin_0,
-                m.IsCall(_, function_matcher, receiver, context_matcher));
-
-    Node* arg1 = m.Int32Constant(0xabcd);
-    Node* call_js_builtin_1 =
-        m.CallJSBuiltin(Context::SUB_BUILTIN_INDEX, receiver, arg1);
-    EXPECT_THAT(call_js_builtin_1,
-                m.IsCall(_, function_matcher, receiver, arg1, context_matcher));
-  }
-}
-
-
 TARGET_TEST_F(InterpreterAssemblerTest, CallIC) {
   TRACED_FOREACH(interpreter::Bytecode, bytecode, kBytecodes) {
     InterpreterAssemblerForTest m(this, bytecode);
     LoadWithVectorDescriptor descriptor(isolate());
     Node* target = m.Int32Constant(1);
     Node* arg1 = m.Int32Constant(2);
     Node* arg2 = m.Int32Constant(3);
     Node* arg3 = m.Int32Constant(4);
     Node* arg4 = m.Int32Constant(5);
     Node* call_ic = m.CallIC(descriptor, target, arg1, arg2, arg3, arg4);
@@ skipping 22 matching lines @@
         feedback_vector,
         m.IsLoad(kMachAnyTagged, load_shared_function_info_matcher,
                  IsIntPtrConstant(SharedFunctionInfo::kFeedbackVectorOffset -
                                   kHeapObjectTag)));
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8