[runtime] Move binary operator fallbacks into the runtime.

src/compiler/interpreter-assembler.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_INTERPRETER_ASSEMBLER_H_
 #define V8_COMPILER_INTERPRETER_ASSEMBLER_H_
 
 // Clients of this interface shouldn't depend on lots of compiler internals.
 // Do not include anything from src/compiler here!
 #include "src/allocation.h"
 #include "src/base/smart-pointers.h"
 #include "src/builtins.h"
 #include "src/frames.h"
 #include "src/interpreter/bytecodes.h"
+#include "src/runtime/runtime.h"
 
 namespace v8 {
 namespace internal {
 
 class CallInterfaceDescriptor;
 class Isolate;
 class Zone;
 
 namespace compiler {
 
@@ skipping 54 matching lines @@
 
   // Load the TypeFeedbackVector for the current function.
   Node* LoadTypeFeedbackVector();
 
   // Call an IC code stub.
   Node* CallIC(CallInterfaceDescriptor descriptor, Node* target, Node* arg1,
                Node* arg2, Node* arg3, Node* arg4);
   Node* CallIC(CallInterfaceDescriptor descriptor, Node* target, Node* arg1,
                Node* arg2, Node* arg3, Node* arg4, Node* arg5);
 
-  // Call JS builtin.
-  Node* CallJSBuiltin(int context_index, Node* receiver);
-  Node* CallJSBuiltin(int context_index, Node* receiver, Node* arg1);
+  // Call runtime function.
+  Node* CallRuntime(Runtime::FunctionId function_id, Node* arg1, Node* arg2);
 
   // Returns from the function.
   void Return();
 
   // Dispatch to the bytecode.
   void Dispatch();
 
  protected:
   // Close the graph.
   void End();
 
   // Protected helpers (for testing) which delegate to RawMachineAssembler.
   CallDescriptor* call_descriptor() const;
   Graph* graph();
 
  private:
   // Returns a raw pointer to start of the register file on the stack.
   Node* RegisterFileRawPointer();
   // Returns a tagged pointer to the current function's BytecodeArray object.
   Node* BytecodeArrayTaggedPointer();
   // Returns the offset from the BytecodeArrayPointer of the current bytecode.
   Node* BytecodeOffset();
   // Returns a raw pointer to first entry in the interpreter dispatch table.
   Node* DispatchTableRawPointer();
   // Returns a tagged pointer to the current context.
   Node* ContextTaggedPointer();
 
+  // Returns an empty frame (used as a placeholder until we can actuall deopt).

[rmcilroy, 2015/09/10 10:28:25]

We will never be deopting the interpreter bytecode handlers, so this isn't a
placeholder. We should really only be calling runtime functions which can't
cause deopts - what is the situation for the new runtime functions, why do they
need FrameStates? Could we special case them in Linkage::FrameStateInputCount so
that they don't require frame states? 

[Benedikt Meurer, 2015/09/10 10:31:12]

Hm, you're right, the frame state can be empty here, because it's only required
to fullfil the API needs. So what you're suggesting is basically a special
GetRuntimeCallDescriptorForInterpreter, which avoids the frame state input?

[rmcilroy, 2015/09/10 10:43:22]

If it's safe to do this, then yeah I would be fine with it (it could also just
be an option passed to GetRuntimeCallDescriptor since that function already
potentially returns a CallDescriptor::kNoFlags if Linkage::FrameStateInputCount
says the function doesn't need a frame state.

+  Node* EmptyFrameState();
+
   // Returns the offset of register |index| relative to RegisterFilePointer().
   Node* RegisterFrameOffset(Node* index);
 
   Node* SmiShiftBitsConstant();
   Node* BytecodeOperand(int operand_index);
   Node* BytecodeOperandSignExtended(int operand_index);
 
   Node* CallIC(CallInterfaceDescriptor descriptor, Node* target, Node** args);
   Node* CallJSBuiltin(int context_index, Node* receiver, Node** js_args,
                       int js_arg_count);
@@ skipping 17 matching lines @@
   bool code_generated_;
 
   DISALLOW_COPY_AND_ASSIGN(InterpreterAssembler);
 };
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_INTERPRETER_ASSEMBLER_H_